Reconnection strategy documentation about javaphoenixclient HOT 8 CLOSED

from javaphoenixclient.

In my case there is one requirement:
The WS connection has to be open no matter what as long as users did not terminate it by closing the app/screen.

So I do try to reconnect on every error.

from javaphoenixclient.

@dsrees I went through the code and here is what I found:

1. I think you are closing the WS with wrong error when the heartbeat times out. Here you should probably pass WS_CLOSE_SOCKET_EXCEPTION if you want to trigger reconnectTimer.
2. The next problem is in the same line. You are calling this.connection?.disconnect(...) but this basically tries to call .close(...) on the OkHttp Websocket. This does not work because the WS is already closed so no callback will be invoked.

I've been able to reproduce this problem using android emulator and Network Link Conditioner

On a side note. I was a bit confused when I saw this . Don't you think it is strange that this is in a Transport class just to trigger reconnectTimer in the Socket when all of the reconnection logic is in that class. Is there any reason why this is not handled in the Socket?

from javaphoenixclient.

One more thing. The Socket.reconnectTimer will be scheduled only once. Because it is never scheduled again after its callback is invoked. This could be simply fixed by scheduling it here.
The one thing I'm not sure about is how it will work with the Channel.rejoinTimer. This one is being scheduled properly but if the connection is dropped it won't be able to reestablish the WS connection.
WDYT?

from javaphoenixclient.

@AdamGrzybkowski Thanks for digging into this! It's appreciated. I'll be able to look into this more this weekend

from javaphoenixclient.

Made a few changes over the weekend. Need to update the tests to match. Will update when I get closer to fixing these up.

from javaphoenixclient.

I've resolved the issues regarding the heartbeat timing out and made some changes to the Transport layer to better mimic the JS websocket protocol.

Leaving this issue open since I'll still need to investigate the reconnectTimer only being scheduled once

from javaphoenixclient.

reconnectTimer will be scheduled each time the connection is closed. Changes will be available in the next release

from javaphoenixclient.