[DS-44] Monthly statistics skip first and last of month - ID: 2541435 about dspace HOT 6 CLOSED

stuartlewis said:

More data from SF issue: 2541435

http://sourceforge.net/tracker/?func=detail&atid=119984&aid=2541435&group_id=19984

Date: 2009-03-31 22:27
Sender: dishimitsu

Hi Stuart,

Thanks for the fix. I actually opted to adjust the beforeDate and
afterDate functions to be exclusive. Same effect, since it only gets called
twice, and the other time doesn't matter if it's inclusive/exclusive.

Thanks,

Date: 2009-03-27 01:55
Sender: stuartlewisProject Admin

Hi Daniel

Thanks for submitting this bug report. Please could you try the attached
file and see if it fixes the issue.

(beforeDate and afterDate are inclusive, so if using them to test to see
if something falls outside of a date range, then you need to use !afterDate
instead of beforeDate, and !beforeDate instead of afterDate).

Thanks,

Stuart

from dspace.

stuartlewis said:

Patch from SF:

Index: dspace-api/src/main/java/org/dspace/app/statistics/LogAnalyser.java
===================================================================
— dspace-api/src/main/java/org/dspace/app/statistics/LogAnalyser.java (revision 3638)
+++ dspace-api/src/main/java/org/dspace/app/statistics/LogAnalyser.java Fri Mar 27 14:46:56 NZDT 2009
@@ -423,12 +423,12 @@
{
// first find out if we are constraining by date and
// if so apply the restrictions

• if (logLine.beforeDate(startDate))
  +if (!logLine.afterDate(startDate)) { continue; }

• if (logLine.afterDate(endDate))
  +if (!logLine.beforeDate(endDate)) { break; }

from dspace.

stuartlewis said:

stat-general seems to be broken. stat-monthly works OK.

from dspace.

stuartlewis said:

The patch for this bug seems to have broken stat-general. stat-monthly is OK.

I think this is because stat-monthly sets start and end dates, but stat-general doesn't (therefore in the code, start and end date are null, and the comparison fails). This seems to be a side effect of the fix for this issue.

The attached patch adds a check for null start and end dates.

Please could someone verify that stat-general is broken on trunk, and confirm the patch fixes it. Thanks.

from dspace.

kshepherd said:

I can confirm that stat-general was returning no data (using latest trunk - rev 4734), and that the problem is fixed after applying the attached patch.

from dspace.

stuartlewis said:

Thanks for the confirmation Kim.

Patch applied to SVN.

from dspace.