Question: should components be stateless? about dspace-angular HOT 3 CLOSED

They can get out of sync if they aren't managed properly

Can you think of an example? As far as I can tell, as long as the variables in the components are observing the state in the store, and not using any other source of information, it's just convenience, and not really a problem.

I checked the ngrx example project, to see how they handle it, and they also seem to use these local observables. e.g. https://github.com/ngrx/example-app/blob/master/src/app/containers/find-book-page.ts#L21

from dspace-angular.

I don't think the observable will get out of sync. I'm just concerned someone might inadvertently reassign the field variable and get unexpected results then. This should be unlikely, as the way to update the state of the app is not by reassigning variables. If possible I'd make the fields final/constant, but converting them to functions would also eliminate the problem.
I guess it's a choice of style. Unless there's a difference in reusing rxjs observables as opposed to getting a new one from the store everytime. (probably not)

from dspace-angular.

I agree it's a good idea to stick with the same style as the ngrx example project.

from dspace-angular.