Comments (6)
To fix the issue of not being able to set the minimum year, I went ahead and changed the default, fallback year to 2015.
from dspace-angular.
I believe this is a duplicate of #1723, which is waiting on a volunteer. We all agree the default minimum date should somehow be more configurable or dynamic.
from dspace-angular.
Looks like the issue with "clicking away" was already addressed in the latest commit for the descendant of this component here with the removal of the blur
parameter:
56ba23f#diff-66188afad0c5a4217693eb10cbef3efd0df661c7a32921a6b1e2b60ecf7c7e8bL11-L23
Curious that they kept [dsDebounce]="250" (change)="onSliderChange($event)"
:
56ba23f#diff-66188afad0c5a4217693eb10cbef3efd0df661c7a32921a6b1e2b60ecf7c7e8bR36-R37
from dspace-angular.
I think this issue is more-or-less resolved. I will keep it open for future review but I feel like I was able to find a solution to my problem(s).
from dspace-angular.
@aseyedia : If this ticket is resolved, then does that mean your PR #3323 was unnecessary? I'm a little confused as to whether you've found that these issues were fixed by #3236 (the recent work you referenced above), or if you still found new bugs?
Ideally, if this ticket is "resolved" we should close it and its PR. It can always be reopened later if we find a reason to do so.
from dspace-angular.
@tdonohue Apologies, allow me to clarify:
In this issue, I (maybe confusingly) outlined a number of small and related issues I had around the "date sidebar search facet."
When I posted #3321 (comment), I was under the impression that #3236 fixed the "clicking away" issue but not the "slider prematurely submitting query" issue. Now I am realizing that even the issue with the slider behavior was resolved. #3236 resolved all of my issues and we can close both this ticket and the PR #3323. Thank you for checking with me.
from dspace-angular.
Related Issues (20)
- Make menus easier to customize
- New ESLint plugins to enforce DSpace-specific coding conventions
- Dspace 8, SortOptions using findAll() not working. HOT 3
- The new user registration form is not accessible to users using a screen reader
- Submission step can't be hidden for only one submission scope
- Community admins wrongly see the button to create top-level communities HOT 2
- Multiple import from external sources isn't shown when the user is member of several groups HOT 1
- Author lookup modal causes bitstream titles to disappear in submission form
- Hanged when submitting a new external source item HOT 1
- Latest value is not copied to external source lookup tab
- Search filter change reloads page without warning to user
- [Accessibility] Update tables in Statistics
- Opening a Lookup Relation Modal always brings you to the top of the Submission Form
- Upgrade to Angular 18 HOT 1
- Relationship lookup component displays misleading information HOT 2
- Facet by Relationship and Render Sidebar UUIDs
- Controlled Vocabulary Fields Show Explicit Splitter-Separated Hierarchy and Does Not Automatically Assign Terms HOT 2
- Add link to Documentation from within DSpace User Interface
- Submission form hierarchical tree view has two add buttons, one enabled and the other disabled
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dspace-angular.