Comments (5)
I retested this issue in the sandbox and found, that if you hit save on the itempage as well, it works for me. I did the following:
- Edit a publication, going to the "Relationships" tab
- Click "+Add" next to Authors and attempt to add a new Author
- Select a local author who is already in the system.
- Click "Save".
- Now, the popup hangs for me as well
- So, click elsewhere on the page (the popup will close)
- Click save on the top of the relationship page
- Reload the page -> The related entities are still there.
Still, I see the issue with the hanging popup window, which is not closing itself.
from dspace-angular.
Thanks @Leano1998 for the additional test! I think I realize where I went wrong. I forgot your step 7. I didn't go back and click "Save" at the top of the relationship page. I had assumed the "Save" button on the popup modal was the only button I had to click.
So, this is working. But the behavior of saving a new relationship is slightly confusing & the popup window never closes itself.
from dspace-angular.
I looked a bit into this and think it might be related to this older issue #1371
If I add the following line (which has been removed in this Commit), the window closes for me:
setTimeout( () => {
this.submit.emit();
this.modalRef.close()
},1000);
edit-relationship-list.component.ts (L352)
But I don't fully understand, why it has been removed.
from dspace-angular.
Thanks @Leano1998 for working to track that down. I don't know the answer to your question, but it seems like the code you referenced was removed in #1329 by @atarix83 . This seems to have been over 3 years ago now, so it may be difficult to track down why that change was made.
If you want to simply create a PR to add the fix that works for you, that may be the best approach. That way we can get some additional testers to ensure it also works for them.
from dspace-angular.
Okay, I can create a PR.
from dspace-angular.
Related Issues (20)
- Clicking "Import -> [ANY OPTION]" keeps navbar header disabled HOT 3
- Persist "Pin sidebar"
- Associate forms to collections in the UI HOT 1
- In Profile, a user can see its groups but not related subgroups
- Migration of collections between communities
- Search bar improvements
- Managing Community Hierarchy: reuse the existing code to the UI
- Enable edition/customization of “News” and the default “Non-Exclusive License” HOT 2
- Possibility to edit custom metadata - backend HOT 1
- Improve/refactor Administrator Reports (DS8 Beta feature)
- Improve the usability and design of the file editing area and the permissions themselves
- Export matadata in other bibliographic formats besides .csv (.ris, .enl, .bib) HOT 2
- Enable edition/customization of “Privacy Policy” and “End User Agreement”
- UX improvement of file permissions (Requires discussion and suggestions) HOT 1
- Error when Editing Groups: 'admin.access-control.groups.form.members-list.notification.failure' and 404 Not Found Exceptions in DSpace 7.6 with DSpace CRIS HOT 1
- Crosswalk for Highwire Press (Google Scholar) citation_ metadata tags should be configurable HOT 1
- Discussion: Do we need a UI/UX guide for developers? HOT 3
- dspace-angular-dspace-8.0 i18n add traditional Chinese! HOT 1
- Discussion: should we use http forwards for requests like /handle/<prefix>/<suffix>? HOT 3
- Faulty submission form: arrange more than 3 lines HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dspace-angular.