xDisk - test resource fails when computer is part of a cluster about storagedsc HOT 12 OPEN

Hi,

We had the same issue while configuring disks before provisionning SQL Cluster (4.3.0.0)
Get-Partition always returns multiple disks.

We just added above 'if' statement after Get-Partitions command

$partition = Get-Partition `
-DriveLetter $DriveLetter `
-ErrorAction SilentlyContinue
 
**# Handle cluster disks returned by the Get-Partition commands
if ($partition -is [array] -and $disk) {
$partition = $partition | Where-Object { $_.DiskPath -eq $disk.Path }
}**

Hope it helps.

from storagedsc.

Hi @asdglkjkwekdf , that is some great info. Looks like it should be possible to port over method from MSFT_xDiskAccessPath to MSFT_xDisk. I'll try and put some time aside to do this. But not for a few days yet (this week is all kinds of crazy busy). But if you or someone else gets to it first, let me know you're working on it so we don't duplicate work.

from storagedsc.

I have already ported the code in my environment; but, unfortunately we are not allow to contribute code. The best I can do is report issues in as much detail as I can.

From my testing cloning the xDiskAccessPath code to the get and test methods was all that was required. I did not review the set method; but, I wonder whether that should have been changed as well.

from storagedsc.

Hi @asdglkjkwekdf - no problem. I'll see if I can take a look at this this weekend.

from storagedsc.

Hi @asdglkjkwekdf - sorry about the delay. I'm working on this today.

from storagedsc.

Hi @asdglkjkwekdf - I've made the changes to this now so that xDisk uses the same pattern as xDiskAccessPath. This change will go in as part of #81 which is a BREAKING CHANGE for xDisk, xDiskAccessPath and xWaitForDisk. Please see the details of #81 to see why this change was necessary.

So once this is released you'll need to update your configs slightly.

from storagedsc.

Hello @PlagueHO - Thanks for looking at this. The changes for #81 make sense.

from storagedsc.

Thanks @asdglkjkwekdf - I've merged this change now to Dev. So if you have a change, could you give it a try and see if it resolves your issue?

from storagedsc.

I should be able to give the dev branch a go this week.

from storagedsc.

Tested successfully.

from storagedsc.

Testing with new build more thoroughly indicates we still have an issue.

Set has been fixed however Get and Test have not been fixed

MSFT_xDisk.psm1 (dev branch)
==> Get Partition:

• Get - Ln 95 > Not fixed
• Set - Ln 264 - 268 > Fixed
• Test - Ln 591 > Not fixed

==> Get Volume:

• Get - Ln 98 > Not fixed
• Set - Ln 388 > Fixed
• Test - Ln 636 > Not fixed

Let me know if this does not make sense

from storagedsc.

Hi @asdglkjkwekdf - thanks for reporting this! I'll take a look this week - I'm a bit behind at the moment. Will definitely catch up this weekend though.

from storagedsc.