DropwizardJettyServerAdapter in DropWizard3 causing exception when there are multiple HttpHeaders about dropwizard HOT 9 CLOSED

Hi @hattad. This has already been discussed in #7203. We can't provide a fully correct implementation with the current logback interface. If we'd 'gracefully' handle this, other users would experience strange behavior because their expected headers will be overridden.

Throwing an exception is the best we can do here to warn users that the request cannot be logged correctly.

from dropwizard.

How did dw-2.x handle repeated headers/cookies differently?

from dropwizard.

@mattnelson The DropwizardJettyServerAdapter was introduced in Dropwizard 3.x. Previously, logback's server adapter was used. That one overwrites a header map entry once a new header with the same name is encountered.

from dropwizard.

Based on #7203 (comment), 2.1.x and 4.x behave the same way, last header encountered wins. While technically a bug in all 3 versions, it seems like the change in 3.x to throw the exception is a bit harsh since the versions before and after it won't behave that way.

from dropwizard.

@mattnelson We could have used the DropwizardJettyServerAdapter in Dropwizard 4.x too. The revert of this change was done to prevent having to update our code every time logback changes something.

I've just opened #7962 to prepare Dropwizard 5 and re-introduced the DropwizardJettyServerAdapter because logback doesn't support Jetty 12 yet. So Dropwizard 5.x will use the same logic as 3.x.

If we merge the change to 4.x, we would stay consistent from 3.x onwards.

from dropwizard.

Since the usage here is for logging, would it be acceptable to reduce the repeated headers into a single comma separated value?

https://stackoverflow.com/a/24502264

from dropwizard.

@mattnelson Since the HTTP RFC allows it, I don't have an objection to that. I've just opened #7965 with the required change.

from dropwizard.

@zUniQueX thanks for making the changes. When do you plan on releasing these changes?

from dropwizard.

Hi @hattad. The next Dropwizard versions will probably be released next week.

from dropwizard.