name_slug's dont update upon updating a device hostname. about nsot HOT 2 CLOSED

This is certainly a bug in the post_save hook for Device objects.

See: https://github.com/dropbox/nsot/blob/develop/nsot/models/interface.py#L454-L457

We're accounting for updating Interface.device_hostname but not updating the Interface.name_slug. Normally this could be handled by the model validation built into Interface.save() but the problem is calling the aggregate .update() method on a query set explicitly *does not call save.

So the fix to this is pretty simple...

def update_device_interfaces(sender, instance, **kwargs):
    """Anytime a device is saved, update device_hostname on its interfaces"""
    interfaces = Interface.objects.filter(device=instance)
    for interface in interfaces.iterator():
        interface.device_hostname = instance.hostname
        interface.name_slug = None  # initialize so that model validation resets it to new hostname
        interface.save()

from nsot.

Confirmed. Thanks.

from nsot.