built-in `fetch` in node 20 issues error about dropbox-sdk-js HOT 6 OPEN

@eouia This code snippet is a TypeScript function that utilizes the Dropbox SDK

and this is how I solved the fetch error.

import { Dropbox } from "dropbox";

import { env } from "@/validation/env";
import { Account } from "@/types/db";

export default function dropbox(account: Account) {
  if (!account) {
    throw new Error("Dropbox account not found");
  }

  const customFetch = async (input: RequestInfo, init?: RequestInit): Promise<Response> => {
    const response = await globalThis.fetch(input, init);

    return Object.defineProperty(response, "buffer", {
      value: response.arrayBuffer,
    });
  };

  return new Dropbox({
    fetch: customFetch,
    clientId: env.DROPBOX_ID,
    clientSecret: env.DROPBOX_SECRET,
    accessToken: account.access_token!,
    refreshToken: account.refresh_token!,
  });
}

remember to treat the buffer as an arrayBuffer and not buffer if you want to save to fs.

const nodeBuffer = Buffer.from(arrBuffer);

from dropbox-sdk-js.

We've updated the server configuration. Can you try again now and let me know if you're still seeing this issue?

from dropbox-sdk-js.

Thanks for the report! We're looking into it. I'll follow up here once I have an update for you.

from dropbox-sdk-js.

Thanks. I think this issue is solved now.

from dropbox-sdk-js.

Sorry for reopening.
I found filesDownload also met fetch related issue.

const { result } = await dbx.filesDownload({ path: item.path_lower })

TypeError: res.buffer is not a function
    at /.../node_modules/dropbox/cjs/src/response.js:67:11
    at new Promise (<anonymous>)
    at parseDownloadResponse (/.../node_modules/dropbox/cjs/src/response.js:61:10)
    at /.../node_modules/dropbox/cjs/src/dropbox.js:146:52
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

The built-in fetch of nodeJS (in V18 and V20) has this problem and node-fetch has no issue.
It seems to be using .buffer() method of node-fetch, but the fetch would have .arrayBuffer() instead. As far as I know, node-fetch also serve .arrayBuffer() to solve this issue.

I think the built-in fetch is not compatible with this SDK completely at this moment.

from dropbox-sdk-js.

Thanks! I'll raise this with the team.

from dropbox-sdk-js.