Code Monkey home page Code Monkey logo

Comments (14)

droibit avatar droibit commented on September 27, 2024

@lateef4web
I think that react-native-custom-tabs depends on old react-native.
Just released the new module which supported the latest 0.42.3.
Please try updating the module.

from react-native-custom-tabs.

mzmiric5 avatar mzmiric5 commented on September 27, 2024

@droibit this still seems to be an issue. I'm running RN 0.42.3 and 0.1.4 and still getting the same error message.

from react-native-custom-tabs.

droibit avatar droibit commented on September 27, 2024

@mzmiric5
Hmm... can you share the code to confirm this error?

from react-native-custom-tabs.

lateef4web avatar lateef4web commented on September 27, 2024

@droibit i'm still getting the same error. Could you please test with 'react-native-paystack' SDK. Seems to be an issue with android because IOS is working fine with paystack sdk.

Thanks.

from react-native-custom-tabs.

mzmiric5 avatar mzmiric5 commented on September 27, 2024

@droibit trying to get a minimal repro project on github, since the original project is closed source. I have managed to isolate the issue to including react-native-intercom (or the actual intercom library). As soon as I remove it, the error goes away. So it seems to be some kind of an incompatibility between the two. would be interesting to know if @lateef4web also uses intercom in their app

from react-native-custom-tabs.

lateef4web avatar lateef4web commented on September 27, 2024

The problem started when i installed 'react-native-paystack'. I don't use intercom. But the problem goes away when i remove 'react-native-paystack'. Could you please debug with 'react-native-paystack' sdk.

Thanks.

from react-native-custom-tabs.

mzmiric5 avatar mzmiric5 commented on September 27, 2024

@droibit here's a minimum repro needed to cause it to have this issue on android when using intercom https://github.com/mzmiric5/RN-CustomTabs-Intercom-Error

from react-native-custom-tabs.

lateef4web avatar lateef4web commented on September 27, 2024

@mzmiric5 I guess intercom and paystack SDK reproduce same issue. Please @droibit what is the way forward?
Thanks.

from react-native-custom-tabs.

mzmiric5 avatar mzmiric5 commented on September 27, 2024

@droibit as a possible link between the two, both intercom and paystack use com.android.support:appcompat-v7:25.0.1 that gets shared with the main app. I assume this probably overwrites your use of v7:23 and I guess the v7:25 handles activity starting differently?

from react-native-custom-tabs.

droibit avatar droibit commented on September 27, 2024

@mzmiric5
Thank you for sharing the detailed information and verification repository!!
I will check the cause of this error.

I assume this probably overwrites your use of v7:23 and I guess the v7:25 handles activity starting
differently?

Probably, I think it is the same behavior.
I guess that the interface or behavior of support-customtabs has changed.

from react-native-custom-tabs.

droibit avatar droibit commented on September 27, 2024

@mzmiric5

I assume this probably overwrites your use of v7:23 and I guess the v7:25 handles activity starting
differently?

Probably, I think it is the same behavior.
I guess that the interface or behavior of support-customtabs has changed.

The cause of this error was as you expected!
Activity starting method was different in support-customtabs in v23 and v25.

So, react-native-custom-tabs updates to support support-customtabs of version 25.0.1.
I'm going to release the module that fixed this issue today.

Thank you!

from react-native-custom-tabs.

mzmiric5 avatar mzmiric5 commented on September 27, 2024

can confirm this resolved the issue with rn-intercom, awaiting the npm release. Thanks for resolving this quickly :)

from react-native-custom-tabs.

droibit avatar droibit commented on September 27, 2024

I just published the latest version of 0.1.5.

@mzmiric5
Your cooperation is really appreciated 👍

@lateef4web
Please try updating the module.

from react-native-custom-tabs.

lateef4web avatar lateef4web commented on September 27, 2024

Thanks @droibit, working now.

from react-native-custom-tabs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.