Comments (3)
This is done with the exception of device status, you said that you had an idea for how to implement this cleanly so we probably need to sit down and talk about how exactly this is going to be done.
from capstone-project.
So there needs to be two things happening:
- Functions (or a function, you might only need one) that reads the device handler's Hardware State and updates the UI elements.
- Functions that call the relevant component control functions in the device handler.
Right now you have functions that do both at the same time, the problem with that is you're assuming the requests will be successful and not verifying, and you don't have the means to update the screen when a process changes something automatically. Decoupling the control requests and UI update will solve that issue.
You also added a bunch of your own "state" variables, but that's what the hardware state class is for. You can just read the device handler's instance of that class, which will give you a comprehensive and up-to-date reflection of all the component statuses, including the sensors. You can read it directly every line or copy it to a local variable to save yourself some typing as you read each component, because it's by reference it doesn't make a difference.
from capstone-project.
This should be done unless I forgot something, or we think of something to add to this.
from capstone-project.
Related Issues (16)
- Aborting a brew does not reset progress screen HOT 3
- Hop dispenser labels show up even when you decrease the number of hop cartridges HOT 1
- Define execution code signals for updating UI on status of processes HOT 2
- Styler branch HOT 5
- Complete making Progress screen generic HOT 6
- Add virtual keyboard to type name of custom brew recipes HOT 1
- UI Adjustments HOT 6
- Processes need to calculate remaining time HOT 1
- Pressing the start brewing button when a process is in progress should take you to the process screen HOT 2
- Process status progress bar is briefly full upon entering the screen HOT 1
- Some steps assume states from previous steps HOT 1
- It should be obvious when a Quick Brew has unsaved changes HOT 1
- There should be limitations on the mash temperature HOT 3
- Component control errors HOT 2
- DeviceStatusControls needs to be updated HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from capstone-project.