Code Monkey home page Code Monkey logo

Comments (6)

Drarig29 avatar Drarig29 commented on June 12, 2024 1

Thanks for the reproducible example! This could be a quick fix, but I noticed I have a few other issues related to this.

Like the fact that get.currentRound() should not be a thing anymore, because it's actually possible to have 2 rounds running at the same time: the final and the consolation final of a single elimination match.

And also in double elimination, where a round of the winner bracket can be played a the same time as a round of the loser bracket - although it's not implemented for double elimination yet, but it better be future proof.

from brackets-manager.js.

Drarig29 avatar Drarig29 commented on June 12, 2024 1

I don't have the bandwidth to do it currently. PRs are welcome 😉

from brackets-manager.js.

Tandashi avatar Tandashi commented on June 12, 2024 1

Will make some room for this later today. Feel free to assign this to me if you'd like 😎

from brackets-manager.js.

Drarig29 avatar Drarig29 commented on June 12, 2024 1

@Tandashi Can you maybe make a local patch on your repo for now?

With https://www.npmjs.com/package/patch-package for example.

Thanks for the PR but I won't have my computer for one week, I took some days off.

from brackets-manager.js.

Tandashi avatar Tandashi commented on June 12, 2024

Would it maybe be useful to implement it similar to get.currentMatches but just for rounds?
Meaning get.currentRounds returns an array of all the rounds that can be played. Then the consumer can also sort by number if previous rounds want to be played first for example.

This would also work for both single_elimination and double_elimination.

from brackets-manager.js.

Tandashi avatar Tandashi commented on June 12, 2024

I just implemented the quick fix for now due to time limitations as well :|

from brackets-manager.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.