Comments (6)
Thanks for the reproducible example! This could be a quick fix, but I noticed I have a few other issues related to this.
Like the fact that get.currentRound()
should not be a thing anymore, because it's actually possible to have 2 rounds running at the same time: the final and the consolation final of a single elimination match.
And also in double elimination, where a round of the winner bracket can be played a the same time as a round of the loser bracket - although it's not implemented for double elimination yet, but it better be future proof.
from brackets-manager.js.
I don't have the bandwidth to do it currently. PRs are welcome 😉
from brackets-manager.js.
Will make some room for this later today. Feel free to assign this to me if you'd like 😎
from brackets-manager.js.
@Tandashi Can you maybe make a local patch on your repo for now?
With https://www.npmjs.com/package/patch-package for example.
Thanks for the PR but I won't have my computer for one week, I took some days off.
from brackets-manager.js.
Would it maybe be useful to implement it similar to get.currentMatches
but just for rounds?
Meaning get.currentRounds
returns an array of all the rounds that can be played. Then the consumer can also sort by number
if previous rounds want to be played first for example.
This would also work for both single_elimination
and double_elimination
.
from brackets-manager.js.
I just implemented the quick fix for now due to time limitations as well :|
from brackets-manager.js.
Related Issues (20)
- Add a way to select first or last in storage
- Automatically set results when status is given HOT 1
- generate json object for bracketsViewer.render method HOT 1
- How to place a team in higher place in brackets without playing with other teams? HOT 4
- I have some problem using the libraries HOT 5
- match game count in a double-elimination bracket with BYE HOT 3
- Get bracket results HOT 1
- Controlling the size of groups in a round robin stage HOT 4
- `update.seeding()` and `confirmSeeding()` mess up the status and reorder participants
- Add support for openbracketformat
- Is it possible to disqualify the team from the bracket? HOT 2
- the order of matches in a two way round_robin is wrong HOT 3
- Improve `inner_outer` ordering for >32 players HOT 1
- GSL-style groups HOT 2
- ordering random, new option? it could be... HOT 3
- Error: Not implemented for round robin and double elimination. Ask if needed. HOT 2
- Let users edit the last match's results (do not archive it)
- How to handle multiple stages (round robin then elimination stage) HOT 4
- Error: Selecting {"stage_id":0,"number":2} on table "group" must return a unique value. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brackets-manager.js.