Code Monkey home page Code Monkey logo

Comments (15)

AnderssonPeter avatar AnderssonPeter commented on June 28, 2024 1

Or I guess two tags aarch64 and armhf would be the best, but I'm 99% sure armhf would work on a pi.

from samba.

dperson avatar dperson commented on June 28, 2024 1

Ah, cool thanks. I'll try to get the new branches created and added to builds in the hub soon. I'd missed entirely that it would create tags for them.

from samba.

dperson avatar dperson commented on June 28, 2024

It already is. But I've never run docker on my RasPi, so it's up to you to figure out how to run the right platform version

dperson@tundro$ head -1 docker/samba/Dockerfile*
==> docker/samba/Dockerfile <==
FROM debian:stretch

==> docker/samba/Dockerfile.aarch64 <==
FROM aarch64/debian:stretch

==> docker/samba/Dockerfile.armhf <==
FROM armhf/debian:stretch

from samba.

AnderssonPeter avatar AnderssonPeter commented on June 28, 2024

i meant that if you add a tag like arm at dockerhub people could just run sudo docker run -it --name samba -p 139:139 -p 445:445 -p 137:137/udp -p 138:138/udp -v /data:/mount -d dperson/samba:arm -n As you already have the right dockerfile it should be easy?

from samba.

JessieSuffrage avatar JessieSuffrage commented on June 28, 2024

+1 on @AnderssonPeter's suggestion. Tags appear to be how official images for Node & Debian are managed. Allows for super easy selection from dockerhub, especially when using a UI like Portainer.

from samba.

dperson avatar dperson commented on June 28, 2024

AFAIK (As Far As I Know) there's no way to add a tag via the Dockerfile and / or set it up on docker hub to tag them. I am just a guy that has a normal day job too, there's not even really an API to add a tag to an image on docker hub that I could find.

from samba.

tkodev avatar tkodev commented on June 28, 2024

https://docs.docker.com/docker-hub/builds/#create-an-automated-build seems to suggest tags are branch based?

from samba.

tkodev avatar tkodev commented on June 28, 2024

I appreciate the work you do @dperson - I use this image regularly. Just trying to help!

from samba.

dperson avatar dperson commented on June 28, 2024

Well they're added, let me know if it solves the problem for you.

from samba.

dperson avatar dperson commented on June 28, 2024

Hmm, the builds are failing, it seems (based on the errors) that it's trying to do the build for the ARM systems on x86 systems... not going to work.

from samba.

tkodev avatar tkodev commented on June 28, 2024

Thanks anyway - I forked your repository to play around with, maybe I'll come up with something

from samba.

dperson avatar dperson commented on June 28, 2024

I figured out a way to get docker hub to build them. There are now rpi and armv7hf tagged builds. Please let me know if they work for you. If they do, I'll add them to the README.md documentation.

from samba.

JessieSuffrage avatar JessieSuffrage commented on June 28, 2024

Great work mate! I got Samba installed and working through Docker Hub via the armv7hf tag on a Raspberry Pi 3 running Raspbian Stretch.

I didn't try the rpi image.

Cheers :)

from samba.

dperson avatar dperson commented on June 28, 2024

Glad to hear it. I'll add it to the docs soon.

from samba.

dperson avatar dperson commented on June 28, 2024

Made some changes, the tag names have simplified now there's just armhf. Hopefully no more changes in the naming. Thanks.

from samba.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.