Comments (5)
Thomas, I agree that having extra features may be a good thing in some cases, therefore I prefer to have that enabled/disabled by developers with a configuration switch in NWMatcher. Forcing the feature enabled by default will break consistency between browser having querySelectorAll() and those not having it.
From the test you can see that this was in the intentions of the test author, see here:
http://disruptive-innovations.com/zoo/css3tests/selectorTest.html#target
I instead suggest you also have a configuration helper to be able to control that at will and by default follow specifications. Having consistent results cross-browser is an objective we can't miss.
from nwmatcher.
Simply put, that test is invalid.
It is going beyond the W3C Recommendation into the realm of personal opinion.
We should all be supporting the standards as they are defined without limiting new ideas and extra features.
If you won't remove that test, please at least add a note that mentions that it is a contested test. That way people will not get the impression that an implementation that 'fails' that test is inferior to an implementation that 'passes' it.
from nwmatcher.
As I said that test is the official Selector API test suite, not one I invented.
My car can run at more than 200 Km/hour, still there is a 110 Km/hour limit on the roads and the car must be built in a way the user can respect that limit. Sounds ?
from nwmatcher.
Oh...forgot... I will happily put a notice in the "css3-compat" test for that, as I did for other contested tests like the ":root" pseudo-class.
from nwmatcher.
Ok... I am closing this since everything is now configurable in NWMatcher:
NW.Dom.configure({ SIMPLENOT: false });
will let developers use complex selectors in :not() pseudo-class.
from nwmatcher.
Related Issues (20)
- Are there plans to add support for the /deep/ combinator? HOT 3
- Am I missing something? Where's the minified version?? HOT 3
- exception when using querySelector HOT 2
- TypeError: Cannot use 'in' operator to search for 'compareDocumentPosition' in null HOT 1
- Update site to reference github and latest version. HOT 2
- isNative fooled by simple toString function HOT 4
- Searching for empty attributes in CSS selectors incorrectly matches missing attributes HOT 1
- Invalid npm package HOT 1
- Invalid selector can cause match() to hang HOT 7
- Unable to use selector li:not(.D\(n\)) HOT 5
- Selecting attributes with single character HOT 3
- tag for 1.4.1 is missing HOT 2
- hasAttributes erroneously called on elements that do not support it HOT 3
- Update license to correct SPDX format
- Support for the case insensitive attribute selector tag HOT 2
- lastSlice is not defined in noqsa line 846 HOT 2
- Missing closing parenthesis in nwmatcher-cache.js HOT 3
- Regular expression vulnerability HOT 8
- Selectors on unattached trees HOT 2
- vulnerability in nwmatcher module HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nwmatcher.