Comments (6)
Fixed it locally. Making a PR now. Thanks!
from downshift.
I think that one of the requirements of using this is that when you apply any of the get props functions you must forward all the props regardless of what those props are. I can't think of any way to avoid doing this, even with a data-item-id
type thing. These properties need to make it to the DOM whether it's a data-item-id
or an id
prop. I'm not sure what you mean by:
We could walk up the dom tree to the nearest id attribute (maybe use data-item-id) instead.
Could you clarify?
from downshift.
One thing that I think we could do is document the requirement a little better. While downshift does not have any opinions about how, where, when, or what you render, it does have a strong opinion about what props are applied to the elements you want to hook into the downshift context.
Does that make sense? Should probably document the importance of that better here (PRs happily accepted)
from downshift.
This would mean you would need to apply the id to every element in the Item (could potentially be many). Also this seems quite error prone.
What I mean when an element is clicked, check if its has the id attribute and if check the parent until you hit the component boundary which should definitely have it. Hope that is clear.
from downshift.
Yes, that is clear. I'll fix that now. Thank you!
from downshift.
~/Developer/downshift (master)
😎 $ npm publish --tag beta
[email protected]
from downshift.
Related Issues (20)
- Highlighting is Inconsistent on Toggle Button using `useSelect` HOT 2
- defaultHighlightedIndex will select disabled items HOT 1
- v10
- Is it possible to use JS to set the value of a React + downshift autocomplete dropdown? HOT 1
- Errors in `typings/index.d.ts`
- Select / highlight first item, that is not disabled when using arrow keys to open the menu
- Screen readers read out object code when using useMultipleSelection hook HOT 1
- useCombobox focus-ring during keyboard navigation HOT 3
- aria-selected returned as string instead of boolean
- `onSelectedItemChange` triggers multiple times when `onMouseMove` and `onClick` happens in the same frame HOT 2
- CodeSandbox examples broken, and workaround also broken HOT 6
- Disabled items are highlighted and are selectable by pressing enter after input value change HOT 4
- Dropdown items are not selectable on mobile devices when rendering to a portal element HOT 2
- Pressing shift + tab selects highlighted item HOT 2
- setActiveIndex seems like not working in new Next.js v15 and React 19 HOT 1
- Request: Update/Remove `prop-types` Usage
- Combobox is not reading the items in JAWS HOT 1
- Incorrect use of <label for=FORM_ELEMENT> HOT 8
- Type for `item` property to `useCombobox` too strict HOT 1
- Document Types for Passing Getter-Props Down to Other Components HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from downshift.