Relying on the id attribute for selecting an item fails for compound components about downshift HOT 6 CLOSED

Fixed it locally. Making a PR now. Thanks!

from downshift.

I think that one of the requirements of using this is that when you apply any of the get props functions you must forward all the props regardless of what those props are. I can't think of any way to avoid doing this, even with a data-item-id type thing. These properties need to make it to the DOM whether it's a data-item-id or an id prop. I'm not sure what you mean by:

We could walk up the dom tree to the nearest id attribute (maybe use data-item-id) instead.

Could you clarify?

from downshift.

One thing that I think we could do is document the requirement a little better. While downshift does not have any opinions about how, where, when, or what you render, it does have a strong opinion about what props are applied to the elements you want to hook into the downshift context.

Does that make sense? Should probably document the importance of that better here (PRs happily accepted)

from downshift.

This would mean you would need to apply the id to every element in the Item (could potentially be many). Also this seems quite error prone.

What I mean when an element is clicked, check if its has the id attribute and if check the parent until you hit the component boundary which should definitely have it. Hope that is clear.

from downshift.

Yes, that is clear. I'll fix that now. Thank you!

from downshift.

~/Developer/downshift (master)
😎  $ npm publish --tag beta
[email protected]

from downshift.