uncontrolled warning on console about react-dropdown-tree-select HOT 10 CLOSED

Thanks for reporting this. This is a known issue and #73 will fix this.

from react-dropdown-tree-select.

@mikdatdogru Try with the latest version and let me know if you still see it.

from react-dropdown-tree-select.

I just updated to 1.8.0 and I can still see the error when clicking outside. The other one is harder for me to reproduce, will let you know.

from react-dropdown-tree-select.

@josvegit I was able to repro the click outside issue by:

• Go to demo page: https://dowjones.github.io/react-dropdown-tree-select/#/story/basic-no-extra-styles
• Open the dropdown
• Click outside

It doesn't happen afterwards. Also, as far as I can tell, it doesn't affect the functionality in anyway.

I'll be looking into this.

Please feel free to send a PR if you happen to have a quicker fix.

from react-dropdown-tree-select.

@mrchief thanks for helping. yes, the console warning is repeated once.

from react-dropdown-tree-select.

@mrchief nah seems to work fine anyway, just an annoying console warning that triggers devs :)

from react-dropdown-tree-select.

@mrchief btw good work with this component, using it in production, works great ! Only quirk with it is that search gets slow when the tree becomes very large (15k nodes). Best react component for the job, by far.

from react-dropdown-tree-select.

@josvegit Thanks for the kind words! I'm glad you find it useful.

Regarding the search, would you mind sharing your dataset? If not, can you tell me more about the structure? E.g. How deep the nodes go and so on so I could play around with it?

from react-dropdown-tree-select.

I'm pretty sure I cannot give you the actual data.. even though it probably would not matter at all (don't wanna lose my job :D). The size according to chrome is 177kb. The Data is an array(size 25), each of these elements has between 50-100 children, which then have more children and so on.. Should probably not load all the data at once but w/e .. got deadlines..

from react-dropdown-tree-select.

I don't need the actual data, just an idea of how many levels to look for and overall size of the data. The tree doesn't render all the nodes - only the visible ones. With something like virtualized lists, I think we can reduce that number even further but I'm not sure if the tradeoff is worth the added complexity. Search tree initialization/search is another area that can be improved. It's on my radar, just need to find some weekend for it. :)

from react-dropdown-tree-select.