Comments (3)
Yeah I was thinking we could use a config file instead of all the virtual methods, but the nice thing about the methods is they allow logic so I was torn on it. Maybe we can think of a way to allow both?
First if the method is overridden it should use the override, otherwise if the value exists in a config file it should use that, otherwise it should use whatever default is in the framework code.
I think moving UseSceneBuffer() to the GameInstance is a good idea. Also adding the path as an argument is good too, it would just be ignore by default.
https://docs.godotengine.org/en/3.2/classes/class_configfile.html
from mdframework.
The solution to this issue will be as follows:
- Implement a static class MDConfiguration that reads a config file.
- This MDConfiguration should contain all the default settings currently in the virtual methods, if the setting is not found in the config file it should use that.
- Replace the content of the current virtual methods with a call to MDConfiguration to get the value.
from mdframework.
Please fix #57 in the scope of this issue as well as they are related.
from mdframework.
Related Issues (20)
- Hosting standalone, disconnecting, then hosting server causing infinite-synchronizing for new players HOT 2
- MDReplicatedMember OnValueChangedEvent not called locally
- Console Variable System
- Console doesn't allow inputting a string with spaces as arguments
- Caching of reflection data HOT 1
- Godot 3.3 support? HOT 2
- Support Multiple Local Players (Splitscreen)
- Add Integration Test GitHub Action
- Add Unit Test GitHub Action
- Resolving of Method for MDRpc should be more accurate HOT 1
- GameClock RPCs don't set SenderRpcId + Remove config settings to disable GameClock/Synchronizer HOT 5
- Support Events as MDReplicate OnChange callbacks
- Support categories for OnScreenDebug and toggling rendering of individual categories
- MDRpcId variants should call the function if the passed in Id is the local peer HOT 1
- MDReplicatorNetworkKeyIdMap should consider things outside of session immutable HOT 1
- Resolving private members & methods in inheriting classes HOT 1
- Exported game couldn't find default configuration, crash
- Method number could not be found for class method HOT 3
- Add command to auto generate CustomMDConfigDebug.ini and CustomMDConfigExport.ini
- Naming Conventions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mdframework.