SA1119 is too sensitive for Preprocessor directives in Dotnet Templates about stylecopanalyzers HOT 4 CLOSED

I've opened up another bug with IDE0047 for the same reason.

Here's some code to reproduce.

https://github.com/EdLichtman/UniformPackagesDemo/tree/DemoIDE0047Error

Open up

Final_Demo/Templates/templates/Demo.PackageLibrary/Demo.PackageLibrary.sln

from stylecopanalyzers.

SA1119 is behaving as expected in this case. I recommend filing a bug on the template engine if it is unable to generate valid C# syntax adhering to a common code style.

from stylecopanalyzers.

@sharwell, the thing here (as I understand it) is that the template files are normal csproj and c# files, The template engine uses the extra parenthesis to differentiates preprocessor directives that control "template application" from preprocessor directives that will end up in the generated code. So when editing the template, SA1119 is triggered on those "template-level" directives. Do you agree with this description @EdLichtman?

from stylecopanalyzers.

Even in that case, the expected resolution here would be to either disable SA1119 or write a custom DiagnosticSuppressor for the situation.

from stylecopanalyzers.