SA1010 false positive when list syntax is used in a field initializer about stylecopanalyzers HOT 5 OPEN

.NET 8 and C# 12 were released yesterday and so this is now an issue with production code. For now, I've had to disable the SA1010 rule for our code until this can be fixed. Please can this be fixed as quickly as possible.

from stylecopanalyzers.

I hit this when telling VS to make fixes for Use collection initializers (IDE0028). It will automatically create statements that trigger SA1010. For example:

List<string> foo = [];

from stylecopanalyzers.

I assume that .NET 8 and C# 12 will be released very soon now. This fix is probably trivial, but what do you think about adding a new test project, @sharwell? Should it wait until you are done with your updates to the test projects (#3675 (comment)), or can it be done now? If you would like to wait, do you have any estimate of when you will be done?

from stylecopanalyzers.

I'm unsure if all the various cases are being tracked or accounted for, but I thought I would report that SA1010 also fires during coalesce, coalesce assign, and ternary operations.

List<string>? list = default;

// fires on coalesce
List<string> otherList = list ?? [];

// fires on ternary
List<string> anotherList = list is null ? [] : list;

// fires on coalesce assigement
list ??= [];

from stylecopanalyzers.

Hit this in a few places.

ctors = [.. ctors.OrderByDescending(info => info.GetParameters().Length)];

object result = TypesManager.InvokeGenericStaticMethod(typeof(ServiceLocator), nameof(ResolveMock), [type]);

if (request.OtherEmails != null)
{
    emails = [.. request.OtherEmails.Split([';', ','])];
}

        public static readonly string[] AllBlastRadiusStrings = [SingleNode, SingleCustomer, SingleScaleUnitSlicePartition, SingleScaleUnit, SingleRack, SingleCluster, SingleAZ, SingleRegion, MultipleRacks, MultipleClusters, MultipleAZs, MultipleRegions, Global, Other];

from stylecopanalyzers.