Remove *Permission and *Assert.'s from code about winforms HOT 7 CLOSED

@karelz accepted

from winforms.

I would literally grep for *Assert and *Permission and remove those, then experimentally remove all using statements for System.Security, System.SEcurity.Permissions, and System.Security.Policy and see what if any compile errors you get. Those may be more hits.

from winforms.

A "remove unused" would clean those unused usings up too in one gesture.

from winforms.

Before I go too far on this (there's a lot of them), are we absolutely we want to remove all the SecurityPermission/UIPermission/Assert stuff? I understand they're no-op on .net core, but coreclr/corefx keep a few of them for the parts of code that are shared with .net framework. Are we positive we don't need to do the same thing for winforms?

from winforms.

💭 I'm not sure why we would be removing Debug.Assert calls. I sometimes use those to document assumptions made at different points in code and I wouldn't be surprised to see similar things in some places here.

from winforms.

The CAS asserts, not the debug asserts :)

For instance, https://github.com/dotnet/winforms/blob/master/src/System.Windows.Forms/src/System/Windows/Forms/WinFormsSecurity.cs#L488

from winforms.

Thanks for picking up the issue @kevingosse! I added you to collaborators list. Once you accept, ping me here and I will be able to assign it to you. (assigning to myself temporarily)

@dotnet/dotnet-winforms FYI about collaborator trick (with Read permissions) - see https://github.com/dotnet/winforms/settings/collaboration

from winforms.