Graphics.DrawIcon Applies TranslateOffset Twice about winforms HOT 9 OPEN

Hi @merriemcgaw, @elachlan

After investigating, we found that these line doubles the translation of the image in the x- and y-axes.

On the main branch, this issue has been fixed by #10645.

from winforms.

@Olina-Zhang can your team please test this?

from winforms.

This is my result on main branch.

private void Form1_Paint(object sender, PaintEventArgs e)
{
    Rectangle bounds = new(0, 0, 64, 64);
    e.Graphics.TranslateTransform(64, 32);
    e.Graphics.DrawIcon(Icon, bounds);
    Rectangle rectangleBounds = new(4, 4, 56, 56);
    e.Graphics.FillRectangle(Brushes.Blue, rectangleBounds);
}

Here is the code that does the transform:

If I comment out the transform I get:

from winforms.

@elachlan Verified this issue on ScratchProject of winforms repo, latest .NET 9.0.100-preview.7.24329.1 and .NET Framework, the test results are the same:

.NET 8.0 test result:

from winforms.

@MandiMan Is the top result from framework on .NET9 Preview?

from winforms.

@elachlan I used the project attached to the Issue description to verify it on the latest .NET 9.0.100-preview.7.24329.1 with the following result:

When I add Rectangle rectangleBounds = new(4, 4, 56, 56); , the test result is as follows:

Also, An existing issue on this topic, mentioned in the Issue description, was verified with different results on .NET 8.0 and the latest .NET 9.0.
.NET 8.0 still doesn't reproduce:

.NET 9.0 reproduces it again, but the result is different from the original issue, which was a downward offset, and is now an upward offset:

from winforms.

@SimonZhao888 how difficult is the fix for .NET8/6?

from winforms.

Hi @MandiMan,
And for the existing issue, I can't repo on the main branch

I found that the code in the case project has a manual offset that we need to change it manually, it should be 0.

from winforms.

und that the code in the case project has a manual offset that we need to change manually,

It's hard to assess, but judging from Jeremy's PR, there are a lot of changes made.

from winforms.