Enable CA1414 for all projects about pinvoke HOT 5 CLOSED

After checking it seem that CA1414 is only in FXCop external analysis and still not ported to the new FxCopAnalyzers package so we will have to decide to enable it and when (Only in Release/CI builds or on all builds, knowing that it'll slow down builds)

from pinvoke.

Let's do it: enable Code Analysis on Release builds with at least CA1414 enabled.

Ideally in the process, we consolidate all the .ruleset files to just one or two (for product and test) so we can add/remove rules to apply to all projects.

from pinvoke.

How can this issue have help? What is in need to be done?

from pinvoke.

Ideally implement the rule in FxCop analyzers then install the package in our projects. But simply enabling legacy FxCop for these projects for this rule would work too.
Thanks.

from pinvoke.

CA1414 still hasn't been ported: dotnet/roslyn-analyzers#430

And I'm actually leaning in the opposite direction, since BOOL is so common and U1 so rare, that perhaps we can just drop all the attributes that explicitly state default behavior.

from pinvoke.