Build error (that doesn't break the build?) in Create-PInvokeTxtFile.ps1 about pinvoke HOT 1 CLOSED

Two things here:

1. The build should fail if the powershell command fails to execute.
2. We need to improve the MSBuild condition for including the PInvoke.Extra.targets file in the build process.

First point.

I don't know why the Exec task can't see that error (maybe because powershell.exe does not set a proper exit code?). As a workaround I can set to true the property LogStandardErrorAsError to catch the error.

Second point.

This is happening since we added the PInvoke.Win32 NuProj project and the error is caused due to an empty $(TargetPath) variable. So we should do something like:

Condition=" !$(MSBuildProjectName.Contains('Test')) AND $(TargetPath) != '' "

Instead of

Condition=" !$(MSBuildProjectName.Contains('Test')) AND !$(MSBuildProjectName.Contains('NuGet'))  "

to exclude any project without a $(TargetPath) (NuProj so far) regardless the name.

I wouldn't complicate more that condition to exclude the CodGen projects since they don't have any [DLLImport] decorated method and the increased time for processing those project is only on the build server (since we have the GeneratePInvokeTxt build parameter).

from pinvoke.