Alias does not seem to work during serialization after moving code - still referring types using full name about orleans HOT 9 CLOSED

@ReubenBond , I believe the issue here is that we have moved our types to a class library. Now Orleans cannot find the types in the assembly anymore even though the main project references the class library. Do we need to explicitly add the class library assembly similar to what has been mentioned in other issues like [assembly: GenerateCodeForDeclaringAssembly(typeof(SomeTypeInMyOtherAssembly))] . We are on version 7.2.1 and the only change we have done in our code is move the grain types (records) from the main project to a class library. All the types of have generate serializer and alias attributes.

from orleans.

@SoucianceEqdamRashti the issue is not moving types to a class lib, the issue is that Alias doesn't apply to the OrleansJsonSerializer

from orleans.

@ledjon-behluli , can you elaborate on that? Are you saying I need to explicitly add the new NewtonSoft.Json package to the class library?

To give more context, in the initial setup, everything existed in one project and this worked fine. We created creates in Azure table storage and no issues there. Then we decided to move the models to a class library and that's when we got the issue of the types not being found and also codec not found for a json serializer exception.

from orleans.

@SoucianceEqdamRashti maybe we are talking about two different things, but can you tell me if in the "$type" property, stored in table storage, you had the fully qualified name or not, i mean in the previous setup you had.

from orleans.

Ah, i looked at your initial comment and as you can see the FQN is stored in $type. See: $type":"TIP.AutomationCenter.Orleans.**Api**.Grains.Contracts.ActionReason.ActionReasonTriggerConditionRecord.

Now the namespace changed to: TIP.AutomationCenter.Orleans.**Business**.Grains.Contracts.Country

from orleans.

@ledjon-behluli , yeah the namespace changed initially.

But I also tried to keep the same namespace in the new class library but that didn't make any difference. Got the same error as above. My assumption is that with Alias it shouldn't use the full name to access the types?

from orleans.

@SoucianceEqdamRashti I dont know about keeping the namespace the same, i would assume it would work (regardless of Alias or not), in the otherhand i dont know if 2 types with the same namespace can be deserialized if assembly info is taking into account or not. You could try this with a POC project and just use Newtonsoft.Json to try it out.

Regarding Alias in the context of storage: no it doesnt work! Kinda...See the Alias attribute is used with the Orleans serializer (the default RPC is done with), not with others! And the json serializer (deafult one for storage) doesnt take that into account (so far). You could use the orleans serializer for storage too, and it should work then. I am not sure if you want to do that, since you'll gain this ability but loose readability, and in-place modification...potentially other benefits.

Hope this helps.

from orleans.

Hmm, thanks for the clarification. Perhaps we will just keep the code in one project for now until some of these serializer parts become easier. Thanks again. I will though try with a POC and if anything new comes up I will post it here. Can close this issue for now.

from orleans.

I will though try with a POC and if anything new comes up I will post it here

Please, and @ me if you dont mind

from orleans.