Code Monkey home page Code Monkey logo

Comments (40)

forki avatar forki commented on May 18, 2024

yes this is a major annoyance

from fsharp.

theimowski avatar theimowski commented on May 18, 2024

👍

from fsharp.

forki avatar forki commented on May 18, 2024

any ideas where we need to look?

from fsharp.

braden avatar braden commented on May 18, 2024

I have noticed this also happens occasionally when project files change externally and VS reloads them, unrelated to FAKE. I had suspected F# Power Tools, maybe there is something in common?

from fsharp.

dsyme avatar dsyme commented on May 18, 2024

I'd love to see this fixed, I've seen it somewhat randomly when compiling quite a range of projects with Visual F#.

from fsharp.

ovatsus avatar ovatsus commented on May 18, 2024

I've also seen this. On F# Data I went to some trouble to try to not lock the .dll files, but then the .xml file is still locked :/
fsprojects/FSharp.Data@8734a17

from fsharp.

latkin avatar latkin commented on May 18, 2024

Curious - does this seem to affect only F#, or has anyone experienced it with C#, too? Would also be good to know if this is a long-standing problem, or has this been the case for multiple VS releases?

from fsharp.

ovatsus avatar ovatsus commented on May 18, 2024

This problem has existed at least since VS2012, and I never saw it in C#

from fsharp.

dungpa avatar dungpa commented on May 18, 2024

According to this answer http://stackoverflow.com/questions/6515795/why-is-my-xml-doc-file-always-getting-locked, this code fragment supposes to fix the bug https://github.com/Microsoft/visualfsharp/blob/fac44095a8dbc7303efa9866e0e2d9dddbdeae5d/vsintegration/src/vs/FsPkgs/FSharp.Project/Common.Source.CSharp/Project/ProjectConfig.cs#L1877-L1896. I'm not sure there is any regression here. Is there any historical note elsewhere about this bug?

For now, this answer seems like a reasonable workaround http://stackoverflow.com/a/3969978.

from fsharp.

rojepp avatar rojepp commented on May 18, 2024

@dungpa If I understand that fix correctly, it fixes for for building in VS only:
When a build starts, ask intellisense to stop locking xml doc. After build is finished, tell intellisense that its ok to lock this file again. This means building from command line will never work properly. How can we tell intellisense to never lock this file?

from fsharp.

dungpa avatar dungpa commented on May 18, 2024

@rojepp

How can we tell intellisense to never lock this file?

No idea. I don't understand why it needs to lock xml files in the first place.

@vladima @KevinRansom @latkin Any pointer to investigate this further?

from fsharp.

latkin avatar latkin commented on May 18, 2024

Ok, just investigated a bit. This repros for C#, as well, at least as far back as VS 2013.

Steps:

  • Create C# library project, add some XML doc comments, make sure project setting to generate doc file is enabled
  • Build, then close VS
  • Create new VS C# project, reference built binary from earlier.
  • Use editor to view XML doc comments via intellisense
  • Try re-building original project on command line via MSBuild
    • This fails due to XML doc file locked

So at least F# is not doing anything worse than C# here.

That's not to say this couldn't in theory be fixed (for all languages). Seems that project systems don't actually touch the XML doc files themselves, they rely on VS platform to handle this (lots of complexities around path to localized XML files, etc). Code here is using IVsXMLMemberIndexService. So the bug (and the fix) is somewhere in the VS platform/SDK, not in the F# codebase.

Maybe I will log a bug on the platform team to look at this.

from fsharp.

rojepp avatar rojepp commented on May 18, 2024

@latkin Please do file a bug and report any progress back here. :)

from fsharp.

forki avatar forki commented on May 18, 2024

@latkin any news about from the platform team?

from fsharp.

dnauck avatar dnauck commented on May 18, 2024

+1

from fsharp.

Arcitectus avatar Arcitectus commented on May 18, 2024

👍

from fsharp.

latkin avatar latkin commented on May 18, 2024

I've found an old internal bug tracking thing. It ended up getting closed, I think just because it was close to a deadline and nobody had a chance to follow up.

I can bring that bug back to life, but first I'd like to know when the issue was introduced. If would help if someone could give positive confirmation whether this repros in VS 2012 and VS 2010, if you have those installed. My steps here #57 (comment) should be valid to repro.

from fsharp.

yukitos avatar yukitos commented on May 18, 2024

I tried VS 2008, 2010, 2012, and this repros in all of them 😢

from fsharp.

dsyme avatar dsyme commented on May 18, 2024

I hit this problem yesterday (I had to restart VS to update some nuget packages due to XML file locking)

from fsharp.

latkin avatar latkin commented on May 18, 2024

FYI, @KevinRansom is poking the VS platform people about this, hopefully more updates next week

from fsharp.

KevinRansom avatar KevinRansom commented on May 18, 2024

The team that owns this code has been identified and a bug raised. We will keep you posted as to progress.
Just to set expectations you should recognize that this behavior has been substantially the same since Whidbey without this bug getting a lot of attention and so they may not be inclined to change it at this time.

from fsharp.

forki avatar forki commented on May 18, 2024

Thanks for opening the issue. Is this a private Microsoft issue tracker or can we see progress/discussion?

from fsharp.

forki avatar forki commented on May 18, 2024

Regarding activity: maybe it wasn't a big issue at the time when the bug got introduced, but since NuGet is used everywhere people see this issue all the time (at least that's what my twitter stream is suggesting for a couple of years)

from fsharp.

latkin avatar latkin commented on May 18, 2024

@forki it's in a private bug database

from fsharp.

KevinRansom avatar KevinRansom commented on May 18, 2024

We'll keep y'all in the loop as my southern wife would say.

from fsharp.

latkin avatar latkin commented on May 18, 2024

This got discussed a bit with platform people over the past few weeks. It's almost surely not going to be fixed for VS 2015 RTM, but it's on their radar perhaps for an early VS update after that. No guarantees , though.

Just wanted to let you know this hasn't totally disappeared into a black hole.

from fsharp.

forki avatar forki commented on May 18, 2024

Ping. Any news on this? It's still no. 1 annoyance for me. Working with cmd line tools like FAKE or git and having solution open is not possible.

from fsharp.

forki avatar forki commented on May 18, 2024

ping

from fsharp.

eiriktsarpalis avatar eiriktsarpalis commented on May 18, 2024

ping++

from fsharp.

TWith2Sugars avatar TWith2Sugars commented on May 18, 2024

pong++

from fsharp.

cdrnet avatar cdrnet commented on May 18, 2024

ping - was just blocked once more where VisualStudio failed to compile an F# project because it was locking the xml file itself (sic) (no FSI or external tools involved).

from fsharp.

KevinRansom avatar KevinRansom commented on May 18, 2024

Lol with the pings. This was fixed in the VS platform, and will be part of VS 2015 Update 1.

Kevin

from fsharp.

eiriktsarpalis avatar eiriktsarpalis commented on May 18, 2024

I just tried the CTP, and can confirm that the problem has gone away. This has easily saved me 20 minutes of work every day. 😃

from fsharp.

rojepp avatar rojepp commented on May 18, 2024

Lovely!

from fsharp.

vasily-kirichenko avatar vasily-kirichenko commented on May 18, 2024

👍

from fsharp.

rodrigovidal avatar rodrigovidal commented on May 18, 2024

\o/ What a day, what a lovely day!

from fsharp.

forki avatar forki commented on May 18, 2024

Wow. That's great to hear. Thanks so much.
On Oct 17, 2015 6:01 AM, "Rodrigo Vidal" [email protected] wrote:

\o/ What a day, what a lovely day!


Reply to this email directly or view it on GitHub
#57 (comment)
.

from fsharp.

forki avatar forki commented on May 18, 2024

@KevinRansom could you please ask if this was also resolved for dll file locking? Can we switch branches from cmd line when VS is open?

from fsharp.

hmemcpy avatar hmemcpy commented on May 18, 2024

Is the CTP containing this fix publicly available? If not, is there an ETA?

from fsharp.

khellang avatar khellang commented on May 18, 2024

@hmemcpy http://blogs.msdn.com/b/visualstudio/archive/2015/10/08/visual-studio-2015-update-1-ctp.aspx 😄

from fsharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.