Navigate to external metadata doesn't work about fsharp HOT 8 CLOSED

@CyrusNajmabadi @tmat do you folks happen to know how does roslyn navigate to the external source? Might be good idea for us to properly support it. We'll likely want to do it in following order: show source link if available, then show F# decompilation (or rather high level representation).

from fsharp.

The main piece of logic for navigating to sourcelink sources starts here: https://github.com/dotnet/roslyn/blob/ca66296efa86bd8078508fe7b38b91b415364f78/src/Features/Core/Portable/PdbSourceDocument/PdbSourceDocumentMetadataAsSourceFileProvider.cs#L66

That call comes in via the IMetadataAsSourceFileService.GetGeneratedFileAsync, which is implemented here, and a File References on that should hopefully reveal where specific features call into it.

from fsharp.

F12 on anything from FSharp.Core or any other .NET library.

VS 17.10 Preview 1

Ugh, again...is it only decompiled metadata?

from fsharp.

Seems so

from fsharp.

It seems to be the issue because roslyn started calling our new IFSharpFindDefinitionService (related issue: #14675) instead of old service. It will be a bit harder to fix since before we were creating an on-demand metadata document, and now we need to provide a document and span.

from fsharp.

Adding @davidwengier our expert here

from fsharp.

Roslyn does the same basic process (source link, then decompilation, then metadata) but I don't think the decompilation system is extensible for other languages. The Source Link stuff might mostly work, but there are probably some gates on it only being done for C#/VB at the moment. For example, we create a project and rehydrate compilation options from the PDB as part of the process, so that stuff probably just fails.

from fsharp.

Roslyn does the same basic process (source link, then decompilation, then metadata) but I don't think the decompilation system is extensible for other languages. The Source Link stuff might mostly work, but there are probably some gates on it only being done for C#/VB at the moment. For example, we create a project and rehydrate compilation options from the PDB as part of the process, so that stuff probably just fails.

Ah, I see. Could you please point me to Roslyn's implementation? I see if I can make a workaround meanwhile.

from fsharp.