Code Monkey home page Code Monkey logo

Comments (4)

MichaelSimons avatar MichaelSimons commented on June 10, 2024

There are two potential issue with using build triggers that we need to look out for.

  1. Previously, the CLI team was manually publishing the Debian packages to the repo after the package was signed off on. This was not part of their automated build process. We need to follow-up with them to see if their process has changed. We could make use of a build trigger if need be.
  2. Docker does not have support for automatically rebuilding dependent images - https://forums.docker.com/t/automatic-re-build-of-depending-images/594. This causes issues with the onbuild image. It must be rebuilt after the base image is built.

from dotnet-docker.

ahmetb avatar ahmetb commented on June 10, 2024

@MichaelSimons valid points but having this is better than nothing and I don't think onbuild image will be impacted with that. Simply if there's a newer build of buildpack-deps:trusty-scm all tags will be triggered to build again from source.

Our builds should be idempotent as in it should not matter when or how many times we're building these images. If there's a critical vulnerability in buildpack-deps:trusty-scm, we need to keep track of those otherwise and manually trigger a rebuild (which I don't think anybody would bother). Makes sense?

from dotnet-docker.

MichaelSimons avatar MichaelSimons commented on June 10, 2024

@ahmetalpbalkan, regarding the onbuild image. This image is based on the Microsoft/dotnet:0.0.1-alpha image. Because of this, the onbuild image must be rebuilt anytime the Microsoft/dotnet:0.0.1-alpha image if rebuilt. More specific, it needs to be rebuilt after the Microsoft/dotnet:0.0.1-alpha image is built. Docker build triggers cause the all images to get rebuilt concurrently. This means the onbuild images produced by these build triggers are incorrect because they are based on the previously built Microsoft/dotnet:0.0.1-alpha image. Again this appears to be a limitation Docker has on their backlog - https://forums.docker.com/t/automatic-re-build-of-depending-images/594

from dotnet-docker.

MichaelSimons avatar MichaelSimons commented on June 10, 2024

I added the appropriate repository links as part of #36.

from dotnet-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.