Release notes plan about core HOT 7 OPEN

@Falco20019 @martincostello @omajid @leecow @rbhanda @baronfel

from core.

That's correct, $schema has no special meaning in the context of plain old JSON serialization. Either removing UnmappedMemberHandling or making sure that it is being mapped to a property should resolve this for you:

[JsonPropertyName("$schema")]
public Uri? Schema { get; init; }

from core.

You could have a separate repo on dotnet for the tooling. Would make sense also for the nuget package linking to it. Then you can release it as dotnet tool for easy usage as global tool (most propably what you suggested).

from core.

I just found a minor issue with https://github.com/dotnet/core/blob/main/release-notes/6.0/supported-os.json#L341

10-20h2-e-lts does not exist, only 10-20h2-e which is already correclty in unsupported-versions. If I don't forget it, I will do a PR.

from core.

I found that added a $schema node can be a breaking change.

I did the following (in order, going back a bit):

• Wrote tools to process the various JSON files in the repo.
• Wrote a tool to generate schema files.
• Ran the tools.
• Added [JsonUnmappedMemberHandling(JsonUnmappedMemberHandling.Disallow)] to the OM and re-ran the generation tool.
• Manually added a $schema node to some of the JSON files
• Time passed
• Re-ran the tools. They broke.
• Error: Unhandled exception. System.Text.Json.JsonException: The JSON property '$schema' could not be mapped to any .NET member contained in type 'DotnetRelease.OSPackagesOverview'.
• Commenting out the JsonUnmappedMemberHandling attribute on the root object in the OM solved the problem.

The long and short of it is the following:

• Adding a $schema node after the fact can break consumers, if they have their own custom OM.
• Adding a $schema node prevents the use of JsonUnmappedMemberHandling.Disallow on the root object.

If there is something I'm doing wrong, that would be good to know. I don't think this finding is a huge problem, but it should influence our use of the $schema node and how we construct the schema.

@Falco20019 @eiriktsarpalis

from core.

Interesting finding. I would assume that JsonUnmappedMemberHandling.Disallow should not check $schema as it's a well-known node. But maybe @eiriktsarpalis can give us more insights. Maybe theres another attribute for setting the schema?

from core.

My conclusion is that STJ has no allowance for schemas meaning that the schema node is just another node.

from core.