ResolveNuGetPackages causes unbounded growth of NuGet cache about buildtools HOT 3 CLOSED

I see the same behavior! Now I know why my VM is running out of disk space 😄

I debugged into the task and found out that in ResolveNuGetPackages.cs#L221 a new temp folder is generated with the package contents each time this line is executed. I suppose it tries to read the manifest and somehow inadvertently extracts the package file to disk instead of reading it in memory.

The ManifestDeclaration class is in the NuGet.NuManifest package, which shows @terrajobst as the author, but I can't find the source code online anywhere.

/cc @terrajobst @weshaggard please take a look

from buildtools.

FYI I have a fix for this that I will be posting shortly.

On Mar 15, 2015, at 1:32 PM, Alexander Köplinger [email protected] wrote:

I see the same behavior! Now I know why my VM is running out of disk space

I debugged into the task and found out that in ResolveNuGetPackages.cs#L221 a new temp folder is generated with the package contents each time this line is executed. I suppose it tries to read the manifest and somehow inadvertently extracts the package file to disk instead of reading it in memory.

The ManifestDeclaration class is in the NuGet.NuManifest package, which shows @terrajobst as the author, but I can't find the source code online anywhere.

/cc @terrajobst @weshaggard please take a look

—
Reply to this email directly or view it on GitHub.

from buildtools.

It looks like the temp caching is happening in https://github.com/Haacked/NuGet/blob/9f25709fafb0d8e8fc2a3b34c1b77a1cb4b8a539/src/Core/Packages/OptimizedZipPackage.cs. So it would appear that @eatdrinksleepcode fix should work nicely for this issue.

from buildtools.