Code Monkey home page Code Monkey logo

Comments (4)

RehanSaeed avatar RehanSaeed commented on May 19, 2024

The NoTrailingSlashAttribute is used to tell the RedirectToCanonicalUrlAttribute filter that the URL does not need a trailing slash. It does not help with the IUrlHelper although it would be nice if it did. I'm not sure there is an extensibility point for me to add this feature, so for now I use .TrimEnd('/') when using the IUrlHelper with these particular URL's.

Perhaps you could raise an issue on the ASP.NET MVC GitHub project, explaining the reason why some URL's need trailing slashes removed and also linking to this issue. If not, I'll raise one when I get a chance.

I've fixed the above issue and will do a patch release. Let me know if you find any others. Thanks @dotnetshadow.

from templates.

dotnetshadow avatar dotnetshadow commented on May 19, 2024

Oh thank you for clearing that up it makes sense after you explained. I'll see if I can raise an issue but perhaps they will listen to you more hehehe

I think you need the same fix on manifest.json

<link rel="manifest" href="@Url.RouteUrl(HomeControllerRoute.GetManifestJson)">

Also as a side note I noticed with the browserconfig.xml stuff that the image won't show up when testing on localhost. I think there is a restriction on how metro apps can talk to localhost maybe worth mentioning in notes somewhere. Basically I tried to pin the website to my Windows 10 start menu it did pin but the image wouldn't show up if I was using localhost.

from templates.

RehanSaeed avatar RehanSaeed commented on May 19, 2024

Fixed. I have raised this issue on the ASP.NET MVC GitHub page.

from templates.

dotnetshadow avatar dotnetshadow commented on May 19, 2024

Excellent good work, hopefully they can have a fix for this well done

from templates.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.