console.log not called in server.start callback about graphql-yoga HOT 5 CLOSED

I agree both syntax options should work. This should and can be fixed in start(), checking if the first parameter is a function.

from graphql-yoga.

I believe this is related to recent pull request 77 it looks like the callback isn't the first argument anymore. Shouldn't it be? since options are optional, shouldn't they go after?

from graphql-yoga.

Indeed changing the function call to:
server.start(null, () => console.log("Server is running on http://localhost:4000"));
fixes the problem and the callback gets executed. One could either change all the boilerplates and the docs to reflect this api change, or one could put the callback as the first argument. I'm in favor callbacks first.

from graphql-yoga.

I suppose that a good implementation with no options and a callback keeping with js conventions, would be:

const options = {}
server.start(options, () => console.log("Server is running on http://localhost:4000"))

I'd be cool with that, but then you gotta merge my pull requests for updating all of the examples and docs.

from graphql-yoga.

Both syntax options should be supported. This rather looks like a bug to me. @kbrandwijk what are your thoughts?

from graphql-yoga.