Comments (3)
felipeelias
commented on May 9, 2024
Correct me if I'm wrong, but the main issue here is regarding the uid and secret being shown in applications#show, right?
If that's the main point, I'd rather focus on the issue #37 which is related to client ownership, so then we can display the uid/secret only for those who are owners (or creators) of the app.
What do you think?
from doorkeeper.
jaimeiniesta
commented on May 9, 2024
Yes, my main concern is that uid and secret are being shown to users and they shouldn't see this.
It's somehow related to the application ownership feature, but as this feature can take a while to be discussed and implemented, I think that by now the best option is to remove the link and just show the name of the authorized applications.
from doorkeeper.
felipeelias
commented on May 9, 2024
For now I just removed the link which seems reasonable.
In my opinion, users will end up changing those views anyway, but this makes sense as a starting point.
from doorkeeper.
Related Issues (20)
- Option to enforce that clients use PKCE HOT 3
- Support OAuth DPoP HOT 1
- reuse_access_token config should be used when refreshing a token HOT 3
- App is not generating the Oauth2 token using doorkeeper gem HOT 2
- MAJOR ISSUE - matching_token_for not considering custom attributes HOT 1
- Issue with defining application_class in Doorkeeper config causing NoMethodError
- Do not recommend setting access_token_expires_in to nil HOT 1
- It is not possible to revoke refresh token bound to the expired access token HOT 3
- Enhancement: expose `current_resource_owner` to views
- Better support for credential rotation
- Always requiring `redirect_uri` is not compliant to RFC 6749 HOT 2
- NotImplementedError error response must define #exception_class after upgrading to 5.6.7 from 5.6.6 HOT 4
- NoMethodError: undefined method `name_for_response' since v5.6.8 HOT 3
- Doorkeeper::Errors::InvalidRedirectUri Raised When No Redirect URI Set HOT 2
- OpenId Connect - No e-mail information in the SSO response
- How do I know if an application has been authorized by a resource owner? HOT 1
- Regression with Errors in 5.6.8 HOT 5
- Refreshing a token sending scopes separated by `+` does not work
- Cleanup job removes not expired tokens HOT 1
- Different access grants return the same access token with `reuse_access_token` enabled
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from doorkeeper.