Code Monkey home page Code Monkey logo

Comments (4)

toupeira avatar toupeira commented on July 18, 2024

@yourtallness the public key is provided to clients through the OIDC discovery mechanism, specifically through the standardized /.well-known/openid-configuration endpoint which points to our custom /oauth/discovery/keys endpoint (see https://github.com/doorkeeper-gem/doorkeeper-openid_connect#routes).

Additionally, if we are not using the implicit flow that returns the id_token (e.g. we use the authorization code flow only), we can skip this configuration, correct?

Turns out the gem requires the signing_key even if no id_token is being requested.

Not sure I follow, AFAIK an ID token is always returned in some form when the openid scope is requested. If that scope is not included, this gem shouldn't become active and you're dealing with a normal OAuth flow from the Doorkeeper gem.

from doorkeeper-openid_connect.

yourtallness avatar yourtallness commented on July 18, 2024

I mean that we don't use the implicit flow that returns the id_token.

Our clients will be hitting the userinfo endpoint to obtain the user information.

from doorkeeper-openid_connect.

toupeira avatar toupeira commented on July 18, 2024

@yourtallness ok thanks I was confused, I checked the specs and it's possible to send a request with response_type=code where no ID token is returned: https://openid.net/specs/openid-connect-core-1_0.html#Authentication

Can you post the exact error you're running into?

I'm wondering if it would be sufficient to specify nil as default for signing_key in Doorkeeper::OpenidConnect::Config:

(if you could quickly verify, that would be also great!)

from doorkeeper-openid_connect.

yourtallness avatar yourtallness commented on July 18, 2024

Turns out the client had to interface with actually required the id_token to be included in the access_token response, so the use case in the original post is now not applicable to us.

FWIW, I set the signing_key to nil and it worked.
Thanks for the support!

from doorkeeper-openid_connect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.