Using and add dependency jwt instead of json-jwt about doorkeeper-openid_connect HOT 7 CLOSED

JWK support was missing (until recently) from jwt. It now has support for that.

from doorkeeper-openid_connect.

That's true! We have contributed to get JWK on ruby-jwt gem. In the next time I will publish a PR for doorkeeper-openid_connect with ruby-jwt.

from doorkeeper-openid_connect.

@phlegx not sure, when I originally added json-jwt in 2016 I think there was some functionality I was missing in the jwt gem.

In case you're already familiar with jwt, do you want to submit a PR? We only have four locations where json-jwt is used (grep for JSON::) so it should be fairly straightforward. If not I'll give it a try, but might take a while until I get around to it ;-)

from doorkeeper-openid_connect.

Here you can see the differences:

Gem jwt supports more verification methods and has over 2.800 follower and gem json-jwt has only 237 follower.

from doorkeeper-openid_connect.

I need to wait for a PR merge and new release of the gem jwt. Then I have the code already prepared to move from gem json-jwt to jwt.

from doorkeeper-openid_connect.

See #177

from doorkeeper-openid_connect.

@phlegx Should this issue be closed now that #177 was merged?

from doorkeeper-openid_connect.