Comments (5)
@Niltz thanks, can you give some more details on the errors you're seeing? I'm not sure if this is related to this change, as it seems that's the only file where we deal with client
.
from doorkeeper-openid_connect.
@toupeira The issue seems to be in the code to get the audience
for the id token. https://github.com/doorkeeper-gem/doorkeeper-openid_connect/blob/master/lib/doorkeeper/openid_connect/id_token.rb#L49. If there's no client_id passed in, there's no application so @access_token.application.uid
this fails with a NoMethodError (undefined method 'uid' for nil:NilClass)
FATAL
FATAL NoMethodError (undefined method `uid' for nil:NilClass):
FATAL
FATAL doorkeeper-openid_connect (1.6.0) lib/doorkeeper/openid_connect/id_token.rb:49:in `audience'
doorkeeper-openid_connect (1.6.0) lib/doorkeeper/openid_connect/id_token.rb:19:in `claims'
doorkeeper-openid_connect (1.6.0) lib/doorkeeper/openid_connect/id_token.rb:28:in `as_json'
doorkeeper-openid_connect (1.6.0) lib/doorkeeper/openid_connect/id_token.rb:32:in `as_jws_token'
doorkeeper-openid_connect (1.6.0) lib/doorkeeper/openid_connect/oauth/token_response.rb:12:in `body'
doorkeeper (5.0.0) app/controllers/doorkeeper/tokens_controller.rb:6:in `create'
app/controllers/tokens_controller.rb:11:in `create'
actionpack (5.2.2) lib/abstract_controller/base.rb:194:in `process_action'
actionpack (5.2.2) lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
from doorkeeper-openid_connect.
I'm running exactly into this issue. Is this still being maintained ?
from doorkeeper-openid_connect.
@natashad thanks for looking into this! Still not sure how we should fix this though, according to the spec the client_id
MUST be returned:
REQUIRED. Audience(s) that this ID Token is intended for. It MUST contain the OAuth 2.0
client_id
of the Relying Party as an audience value.
But looking at this article it seems it's also acceptable to return the username sent by the client as client_id
.
Unfortunately AFAICT we don't have access to that in Doorkeeper, since the user has to implement resource_owner_from_credentials
and we only get the final resource owner object.
I wonder if it's also okay to return resource_owner.id
? Does anybody have access to another OIDC provider which supports password grant, and can report what they return for client_id
?
Is this still being maintained ?
@alduro barely, it's mostly just me ;-) Any help is welcome!
from doorkeeper-openid_connect.
The problem with the audience
claim should now be fixed with #99 released in 1.7.1, feel free to reopen if you're still experiencing issues!
from doorkeeper-openid_connect.
Related Issues (20)
- `/.well-known/openid-configuration` crashes when `Doorkeeper.config.allow_token_introspection` is false HOT 1
- Shouldn't controllers inherit `Doorkeeper::ApplicationMetalController`? HOT 1
- Using `root_url` in `#webfinger_response` can violate specification HOT 1
- `access_grant_class` is broken. HOT 7
- Possible to disable `client_secret_basic` for `token_endpoint_auth_methods_supported`?
- RP-initiated logout post_logout_redirect_uri is not validatable
- Broken with Doorkeeper v5.6.3
- uninitialized constant Doorkeeper::JWT::JWK in 1.8.4 HOT 8
- OpenID working with rails app HOT 5
- Support for sessions and session_state HOT 1
- Support multiple devise models
- `kid` value in headers in different format after upgrading from 1.8.3 to 1.8.5 HOT 2
- Missing v1.8.5 tag HOT 2
- NameError: uninitialized constant Doorkeeper::JWT::JWK HOT 6
- kid is different for different versions of doorkeeper-openid_connect HOT 1
- Certificate verify failed from SSL
- Doorkeeper patch v5.6.8 modified exception handling to require objects instead of symbols HOT 2
- some combinations of prompt causes double rendering/redirection
- Support dynamic signing_key
- Customize webfinger responses
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from doorkeeper-openid_connect.