Code Monkey home page Code Monkey logo

Comments (7)

arianvp avatar arianvp commented on June 19, 2024 2

I'm running into exactly the same issue.

from doorkeeper-openid_connect.

toupeira avatar toupeira commented on June 19, 2024 1

Apologies for the long delay, and happy new year everyone! 😁

I'm not really sure how the native authorization works, but #60 should fix the exception.

Please try again with the new version 1.5.3.

from doorkeeper-openid_connect.

toupeira avatar toupeira commented on June 19, 2024 1

@nhosoya great, thanks for checking! 👍

from doorkeeper-openid_connect.

toupeira avatar toupeira commented on June 19, 2024

Thanks for the report!

What version of doorkeeper-openid_connect are you on? Does this still happen with 1.5.2?

Also, can you describe how to reproduce the error?

from doorkeeper-openid_connect.

nhosoya avatar nhosoya commented on June 19, 2024

This error is reproduced with

ruby 2.5.1
rails 5.2.1
doorkeeper 5.0.0
doorkeeper-openid_connect 1.5.2

I created minimum repository to reproduce this.
https://github.com/nhosoya/doorkeeper-openid_connect-sample

Steps to reproduce:

  1. Create new oauth application that redirect_uri is urn:ietf:wg:oauth:2.0:oob.
  2. Access to Authorization Endpoint for this application and authorize.
    (Or access directly /oauth/authorize/native?code=aaa)

Only doorkeeper(without doorkeeper-openid_connect), this error is not reproduced.
https://github.com/nhosoya/doorkeeper-openid_connect-sample/tree/only-doorkeeper

from doorkeeper-openid_connect.

a-tommyyy avatar a-tommyyy commented on June 19, 2024

next unless pre_auth.scopes.include? 'openid'

i think this line should be changed like below

next unless pre_auth&.scopes&.include? 'openid' 

from doorkeeper-openid_connect.

nhosoya avatar nhosoya commented on June 19, 2024

It works fine. Thank you, and happy new year! 😃

from doorkeeper-openid_connect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.