`createTag()` of `AttributesTrait` accesses a `private` attribute without a getter about cellbrush HOT 6 OPEN

Currently Tag / AttributesTrait are designed as immutable, so all the setters create copies. Nowadays I call such setters not setSomething(), but withSomething(), or withAddedSomething(). E.g. $car->withColor('blue').

Calling such methods always has a tiny little overhead.

Within a constructor or when an object is being freshly created, the immutable aspect is not really needed. I would prefer to not create object copies for no reason.

Maybe we should have a static method Tag::createWithAttributes($tagName, $attributes) ? Or add this as an optional parameter to Tag::__construct()?

One difficulty with static method constructors is always that they need to call new static or new self, so they might break in a subclass, if the subclass has a different constructor signature. I already kinda dislike AttributesTrait::create() for this reason.

from cellbrush.

[The usage of PHP Traits is quite confusing, isn't it?]

Yes, I use them a lot less nowadays. They do not properly encapsulate anything, and make it really hard for an IDE to figure out what's going on. I wish PHP had real multiple inheritance.

from cellbrush.

Is this not covered by any test, I wonder?

from cellbrush.

Or maybe a good design for immutable classes is to have a base class with protected mutable setters, and then a subclass which is immutable because it only calls those setters during construction?

from cellbrush.

https://twitter.com/brain4lunch/status/786526053640482817 :)

from cellbrush.

"Or add this as an optional parameter to Tag::__construct()"

This solution seems elegant.

from cellbrush.