Comments (3)
Having the same issue here.
Code to replicate:
it('test', async () => {
function reject42() {
return Promise.reject(42);
}
await expect(reject42()).to.be.rejectedWith(999);
});
it('test', async () => {
function reject42() {
return Promise.reject(42);
}
await expect(reject42()).to.be.eventually.rejectedWith(999);
});
In both cases test passes rather than fail.
from chai-as-promised.
@masterpandabear But this is only true, if no rejected value is part of the error. Here are some false-positive example:
const mocha = require("mocha");
const chai = require("chai");
const chaiAsPromised = require("chai-as-promised");
chai.use(chaiAsPromised);
it('test 1', async () => {
function reject42() {
return Promise.reject(new Error('42'))
}
await chai.expect(reject42()).to.eventually.be.rejectedWith('4')
});
it('test 2', async () => {
function reject42() {
return Promise.reject(new Error('42'))
}
await chai.expect(reject42()).to.eventually.be.rejectedWith('2')
});
Both tests are passing, which is not expected (for me), because it's obvious that 42
!= 4
and 42
!= 2
.
Reproducible source code: https://github.com/nilsreichardt/playground/blob/chai-as-promised-error-message-bug/test/index_test.js
from chai-as-promised.
A bit late but I guess this library looks for actual thrown errors for rejected values, for example this fails as expected
it('test', async () => {
function reject42 () {
return Promise.reject(new Error('42'))
}
await expect(reject42()).to.eventually.be.rejectedWith('999')
})
from chai-as-promised.
Related Issues (20)
- should.eventually.be.<boolean> and should.eventually.equal(<boolean>) HOT 1
- Provide browser script HOT 1
- Error: Invalid Chai property: _promise
- not compatible with chai-arrays
- expect(...).to.be.rejected always passes HOT 2
- rejectedWith when error is undefined doesn't work
- rejectedWith Deep Equals
- Implementation of to.eventually.be.pending
- Proxying makes use order matter with chai-exclude and chai-as-promised HOT 1
- node 15, eventually.throw ? HOT 2
- Printing stacktrace whenever a promise is rejected HOT 1
- Does not work well with bluebird.
- Syntax Error: /node_modules/chai-as-promised/lib/chai-as-promised.js:5:1 HOT 1
- Duplicate packages detected in the chaiaspromised project on Tag: v7.1.1
- .eventually assertion doesn't fail when Error message mismatch. HOT 2
- Asserting a rejcted promise to not be rejected succeeds HOT 1
- Overloading `rejectedWith` to handle `undefined` input
- Feature request: Support for es6 modules HOT 1
- Chai v5 support HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chai-as-promised.