Comments (3)
You are correct that extensions with yacc grammars are more or less impossible. Your best bet would be to fork the project to make the customizations you want.
What we could do on the go-mysql-server side is make the parser pluggable the way other parts of the engine are. It's kind of a lot of work to transform the vitess AST into the go-mysql-server query plan tree though, and it would be a pretty fragile extension point.
Do you have some examples of what you're talking about that we could examine?
from vitess.
First of all, sorry for my late reply.
One example is dealing with postgres schemas. When connecting to postgres from an external query engine, one needs a path syntax like: <db>.<schema>.<table>
as table identifier. By parsing this as a path instead of a <id>.<id>
one can future proof the identifiers. This is the approach taken by calcite and presto.
This comes up a lot when adapting existing DB SQL dialects and there seems to be three ways:
- Fork the parser for each use case and then many parallel implementations.
- Switch from yacc to some other grammar solution that supports extension. Calcite has that for example.
- Accept PRs with all sorts of changes to the parser that are then filtered out and discarded during analysis of the AST if not needed.
2 is usually considered to be the best solution but that would require you to switch parser generator. Not a very fun prospect.
ANTLR can be extended and has a GO target. Not sure how PEG for GO works.
from vitess.
I did a quick analysis. It would not be too hard for me to translate the parser to ANTLR and keep the compatibility with the query plan tree. That would allow extension, separation of concern and a more "modern" parser generator. However, it would also break the compatibility with vitess.
In calcite, someone use this extensibility to run queries directly from a graphQL parser. 😃
from vitess.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vitess.