Code Monkey home page Code Monkey logo

Comments (2)

dolphingarlic avatar dolphingarlic commented on May 25, 2024

Hi, thanks for the feedback. I've disabled the embeds for commits and PRs. I didn't mind, since they were experimental and a result of Hacktoberfest anyway :P

Also, does the regex work fine in general? I've only tested it on a few repos before.

from git-the-lines.

Al12rs avatar Al12rs commented on May 25, 2024

Ok I've re-enabled the bot. Thanks!
In my experience the regex seamd to always work when we expected it.

Well as I say that I notice that PR code diff Line links don't work.

The links are these and they have a different format than the normal line links. They use R and L to indicate whether they mean the left or right version:

https://github.com/dolphingarlic/git-the-lines/commit/b6fb32e19a60176a951a099e919eb7650cf5eb74#diff-36f6200cd8353111badb874140eba3af6055f4cc5839fbdeb9ede992620828c1R40

https://github.com/dolphingarlic/git-the-lines/commit/b6fb32e19a60176a951a099e919eb7650cf5eb74#diff-36f6200cd8353111badb874140eba3af6055f4cc5839fbdeb9ede992620828c1L40

If you want to support these as well I would only report one of the two lines of the diff, or the embed would become a mess.

I don't think these are too common since people usually use PR code comments instead of discussing on discord in these cases, so I don't know if it's even worth adding.

from git-the-lines.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.