File Download feedback about sbtools HOT 7 CLOSED

Here's an implementation that more or less does it.

https://github.com/dblodgett-usgs/hydroRsb/blob/master/R/model_file_download.R

from sbtools.

I assume this applies specifically to item_file_download()?

from sbtools.

Looking at this - curios in the REST helpers why we only support certain content types? AFAICT sbtools only downloads the files, and doesn't do anything more than that like try to read the file in, etc, -- So could we just allow any file type, esp. with GET requests?

from sbtools.

yeah, I had the same question here: #98

Supported types vs unsupported types.

from sbtools.

to summarize, i think we decided that we didn't really want to specify which types were permitted, but we needed some way to determine whether we were getting an error or not (e.g., user might not be authenticated). checking for known types was the temporary solution.

@sckott, maybe you've already fixed this today with handle_errors (i haven't looked very carefully...)? or maybe there's some other way to check for non-authentication & other errors?

from sbtools.

Okay, thanks. Oh, so, if the content-type header is consistent with an authorization error, then you'd stop on that?

I can write some tests for handle_errors to make sure (ping #128 )

from sbtools.

Sounds good!

from sbtools.