Comments (3)
Example results when running iwyu
with clang-14 against the files mentioned in #3377:
util/bip32.cpp
# python3 ../include-what-you-use/iwyu_tool.py src/util/bip32.cpp -p . -j6 -- -Xiwyu --cxx17ns
util/bip32.h should add these lines:
#include <stdint.h> // for uint32_t
util/bip32.h should remove these lines:
The full include-list for util/bip32.h:
#include <attributes.h> // for NODISCARD
#include <stdint.h> // for uint32_t
#include <string> // for string
#include <vector> // for vector
---
util/bip32.cpp should add these lines:
#include <algorithm> // for copy, max
#include <cstdint> // for uint32_t
util/bip32.cpp should remove these lines:
The full include-list for util/bip32.cpp:
#include <util/bip32.h>
#include <stdio.h> // for size_t
#include <tinyformat.h> // for format, strprintf
#include <util/strencodings.h> // for ParseUInt32
#include <algorithm> // for copy, max
#include <cstdint> // for uint32_t
#include <sstream> // for basic_istream, stringstream
---
util/string.cpp
# python3 ../include-what-you-use/iwyu_tool.py src/util/string.cpp -p . -j6 -- -Xiwyu --cxx17ns
util/string.h should add these lines:
#include <stdint.h> // for uint8_t
util/string.h should remove these lines:
The full include-list for util/string.h:
#include <attributes.h> // for NODISCARD
#include <stdint.h> // for uint8_t
#include <algorithm> // for equal
#include <array> // for array
#include <cstring> // for strlen, size_t
#include <locale> // for locale
#include <sstream> // for ostringstream, basic_ios::imbue
#include <string> // for string
#include <vector> // for vector
---
(util/string.cpp has correct #includes/fwd-decls)
support/lockedpool.cpp
# python3 ../include-what-you-use/iwyu_tool.py src/support/lockedpool.cpp -p . -j6 -- -Xiwyu --cxx17ns
support/lockedpool.h should add these lines:
#include <stddef.h> // for size_t
support/lockedpool.h should remove these lines:
- #include <stdint.h> // lines 8-8
The full include-list for support/lockedpool.h:
#include <stddef.h> // for size_t
#include <list> // for list
#include <map> // for multimap<>::const_iterator, multimap, multi...
#include <memory> // for unique_ptr
#include <mutex> // for call_once, mutex, once_flag
#include <unordered_map> // for unordered_map
---
support/lockedpool.cpp should add these lines:
#include <ext/alloc_traits.h> // for __alloc_traits<>::value_type
#include <limits> // for numeric_limits
#include <stdexcept> // for runtime_error
#include <utility> // for pair, move
support/lockedpool.cpp should remove these lines:
- #include <config/bitcoin-config.h> // lines 9-9
- #include <limits.h> // lines 20-20
The full include-list for support/lockedpool.cpp:
#include <support/lockedpool.h>
#include <ext/alloc_traits.h> // for __alloc_traits<>::value_type
#include <support/cleanse.h> // for memory_cleanse
#include <sys/mman.h> // for size_t, madvise, mlock, mmap, munlock
#include <sys/resource.h> // for getrlimit, rlimit, RLIMIT_MEMLOCK, RLI...
#include <unistd.h> // for sysconf, _SC_PAGESIZE
#include <algorithm> // for min
#include <limits> // for numeric_limits
#include <stdexcept> // for runtime_error
#include <utility> // for pair, move
---
from dogecoin.
👍 from me. I tested the same tool a few weeks ago and it looked useful.
The first item in your list seems like a good first issue too, though it might need the disclaimer "(for someone familiar with compiling)".
from dogecoin.
#3454 is another example of this being useful - running iwyu over src/bench
solved an issue that is (likely) caused by a boost 1.84 header no longer including <limits>
from dogecoin.
Related Issues (20)
- [bug] False positive successes on erroring CI (1.21-dev) HOT 2
- [bug] estimatefee & estimatesmartfee always return -1 as result HOT 18
- [feat]
- What happened to development? [feat]
- Dogecoin node has stopped syncing HOT 24
- transaction details HOT 14
- After funding dogecoin multisig address unable to spend from that wallet address getting spendable false. HOT 17
- 1.14.7 release plan HOT 45
- spam
- [bug] compiling in FreeBSD 14 fails on error HOT 14
- Estimate(smart)fee fixes tracker HOT 2
- feat: translation linter needs to check numerus format HOT 2
- [bug] ERROR: CheckAuxPowProofOfWork : block does not have our chain ID (got 0, expected 98, full nVersion 0) HOT 9
- [bug] 1.14.7: build fails with gcc 14.x HOT 9
- [bug] 1.14.7: compile time warnings HOT 1
- Update minimum platforms for 1.15.0 to update Qt HOT 2
- qa: Non-deterministic behavior in walletnotify.py HOT 3
- [bug] Windows GUI window does not appear. HOT 6
- QA: Cross OS Build Testing & Documentation HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dogecoin.