Comments (4)
Sure. The root of the problem is that you're trying to use conditional comments, Jammit's trying to use conditional comments, and the two don't get along. Would you like to see an option like :ie_only => true
, which would remove the (!IE)
portion? Or would you rather see an :embed_images => false
option, which would return the regular version of the stylesheet for that package only. I'm partial to the latter. If I read your suggestion correctly, that's what you're suggesting.
from jammit.
Alright -- I've got a patch for :embed_images => false
as an allowed option to the include_stylesheets
helper. It will turn off embedded images for just that single asset package, giving you the plain script tag without any conditional comments. Check out the latest version and give it a spin -- you can run rake gem:install
to build a gem for yourself. If it works for you, we can push out a Jammit 0.3.2...
from jammit.
Alright, sorry for the delay. I tried it out, and it seems to work great. Thanks!
from jammit.
Fantastic. Jammit 0.3.2 is out, with the patch. Closing this ticket.
from jammit.
Related Issues (20)
- New gem version? 0.6.6? HOT 17
- Error when running jammit 0.6.5 (ruby 1.9.3 + rails 3.2.8 + windows 7 64-bit) HOT 2
- Templates are not loaded on production
- What will be the max js file size for compression ?
- Segmentation fault when calling rake jammit:package HOT 2
- Per-file compile settings HOT 1
- JSMin should not be the default JS Minifier
- Adding path changes all JST paths HOT 2
- new tag/release needed to apply patch for Rails 4! HOT 8
- Jammit should warn when it fails to load an explicitly configured compressor. HOT 2
- what os the use in document cloud viewer ? HOT 1
- Remove jsmin from dependencies HOT 2
- Is there a way to use jammit independent of rails? HOT 2
- The character sequence backslash single quote breaks jst files
- Where are timestamps? HOT 2
- Produce an optional manifest of files being compiled
- rake aborted! when activesupport-3.0.20 fails to load jammit HOT 2
- NameError (undefined local variable or method `page_cache_directory' for #<Jammit::Controller:0x007f1daee33488>): HOT 4
- DEPRECATION WARNING: append_before_filter is deprecated and will be removed in Rails 5.1. Use append_before_action instead. HOT 1
- sdt
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jammit.