Foreign key name change not picked up by schema comperator about dbal HOT 2 CLOSED

@achterin I think it sounds good, would you like to send a PR with tests showing the issue as well as your change?

from dbal.

@greg0ire sure, I'll give it a shot. The thing is, there is already a test that will fail with my changes in place but I don't understand why doctrine should behave that way.

The test I'm talking about is this one: https://github.com/doctrine/dbal/blob/4.0.x/tests/Schema/AbstractComparatorTestCase.php#L366

To me it seems this test was introduced way back as part of this issue: doctrine/orm#2336

In my opinion a foreign-key name change should always be reflected in a tablediff as it will result in a different schema.
The question is: should i just remove the test or am I missing something entirely and this test tries to test for something else and is just coded in a way so the assertion gets triggered with my changes in place?

Thanks for you help in advance!

Edit: After a little more digging I found that testCompareIndexBasedOnPropertiesNotName once behaved exactly the same but was later changed due to the introduction of renaming indexes. So I guess it will be fine to change the existing test to also reflect my change and expect one fk being dropped and one being added.

Edit2: In my opinion it would also be good to rename the tests as they now test for the complete opposite.

from dbal.