Code Monkey home page Code Monkey logo

Comments (7)

greg0ire avatar greg0ire commented on August 15, 2024

OrderedFixtureInterface doesn't extend FixtureInterface, which probably means something like OrderedFixtureInterface&FixtureInterface should be used somewhere.

from data-fixtures.

greg0ire avatar greg0ire commented on August 15, 2024

Hard to tell where without the source code of tests/Functional/FunctionalTestCase.php, of course.

from data-fixtures.

johanadivare avatar johanadivare commented on August 15, 2024

@greg0ire this is what the class looks like:

xxx

    protected function refreshFixtures(): void
    {
        $loader = new Doctrine\Common\DataFixtures\Loader();
        $fixture = new CustomFixture();
        $fixture->setContainer($this->getKernelBrowser()->getContainer());
        $loader->addFixture($fixture);
        $purger = new Doctrine\Common\DataFixtures\Purger\ORMPurger();
        $executor = new Doctrine\Common\DataFixtures\Executor\ORMExecutor($this->getEntityManager(), $purger);
        $executor->execute($loader->getFixtures());
    }

from data-fixtures.

greg0ire avatar greg0ire commented on August 15, 2024

Ok, so the issue is with

* @psalm-return array<class-string<OrderedFixtureInterface>|int, OrderedFixtureInterface>

Do you feel up to making it more precise?

Kind of makes me wonder why OrderedFixtureInterface doesn't extend FixtureInterface in the first place though 🤔

from data-fixtures.

johanadivare avatar johanadivare commented on August 15, 2024

Ok, so the issue is with

* @psalm-return array<class-string<OrderedFixtureInterface>|int, OrderedFixtureInterface>

Do you feel up to making it more precise?

Kind of makes me wonder why OrderedFixtureInterface doesn't extend FixtureInterface in the first place though thinking

Yes i think its in the Loader.php, i haven't debugged the issue much i could try to change the return types but i also wonder why that OrderedFixtureInterface doesn't extend from FixtureInterface haha i dont know who introduced it maybe they know best.

I saw docs updates where done in #389 but they made it consistent with the property $fixtures docs

from data-fixtures.

greg0ire avatar greg0ire commented on August 15, 2024

i dont know who introduced it maybe they know best

If only there was a way for us to know that, like some kind of code history tool 🤔

Trolling aside it was introduced more than 10 years ago in #5 , so… long shot, but @l3pp4rd , super long shot, but maybe you have some input you can provide on this?

from data-fixtures.

johanadivare avatar johanadivare commented on August 15, 2024

Haha fair, i didn't look that fair back ;p

from data-fixtures.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.