Setting viewportOverrides with Ember.on doesn't work as expected about ember-in-viewport HOT 4 CLOSED

Hey @blimmer, thanks for opening this issue. Your override is most definitely correct, although I would move the super call to come before the setProperties. A PR would be welcome!

from ember-in-viewport.

@poteto I actually think it's important to call _super after setting the properties because _super will call the mixin's didInsertElement before you set the properties. Check it out:

export default Ember.Component.extend(InViewportMixin, {
  didInsertElement() {
    this._super(...arguments);

    console.log('*** IN COMPONENT MIXIN didInsertElement');
  }
});

and the console output:

in-viewport.js:42*** IN IN_VIEWPORT MIXIN didInsertElement
foo-bar.js:6*** IN COMPONENT MIXIN didInsertElement

from ember-in-viewport.

Actually, why do we overwrite the options in the init method anyway?

In my use case, I just want to set the viewportSpy method and it seems weird that it gets overwritten on init. Seems like I should be able to do:

export default Ember.Component.extend(InViewportMixin, {
  viewportSpy: true,
});

What's the reason for overwriting in init and requiring the user to tap into didInsertElement?

from ember-in-viewport.

Closing since the mixin approach is less and less common

from ember-in-viewport.