Review other patches from John Barton about dockpanelsuite HOT 6 CLOSED

Fix for "select correct tab after you close one" cannot be accepted in its current state. It assumes that each tab is killed when it is closed, however you can have tabs that simply hide themselves on close rather than destroy themselves on close. This leads to funny behavior, most notably that a tab that was previously hidden will reappear when the last visible tab is closed.

from dockpanelsuite.

Submitted a revised change.

New class, DockContentCollection.ContentSelector() does the work - and handles the case where content is hidden.

Uses this whenever the visible state of content is changed, so if you programmatically call "IsHidden" on content, it will work.

Tested all the cases I could think of - let me know if you have any further issues.

from dockpanelsuite.

I was too quick uploading that. It didn't work with our improved middle click - where you can middle click to close a tab that isn't selected - and it doesn't change the selection.

I'll upload a new set of changes for this soon.

from dockpanelsuite.

OK, so new set of changes up for selecting the correct tab when you close content. Copes with HideOnClose being true, and copes with the case where you are closing content that isn't selected. Next to upload will be our revised middle-click close fix, that doesn't select the tab before closing it.

from dockpanelsuite.

Sorry this has been hanging out here for a while. I'm concerned this might be a bandaid for a deeper issue but haven't had the opportunity to fully form that opinion yet.

from dockpanelsuite.

Not a problem. I was a little concerned after realising we hadn't coped with documents that were hidden rather than closed - and had to rethink what we had to cope with.

If its of any use, that change has been in our code now for a while and has been released, and hasn't caused any problems.

I promise I'll get around to adding our better fix for middle-click close soon.

from dockpanelsuite.