Display better error message when "ssh-keygen" is missing about machine HOT 4 CLOSED

Currently working on the cloudstack driver (#74), and as i'm developing under Windows 7, i faced the same issue : ssh-keygen is not in the path by default.

Important thing to note is that it works with VirtualBox because i had a full vagrant + openssh setup, so i have a ssh-keygen command in my PATH. But this is not the default setup for a lot of people.

So some solutions :

• Is there a way to handle SSHKeyGeneration inside go, in order to make this action cross platform ? It seems that we have these usefull libs :
  • https://code.google.com/p/go/source/browse?repo=crypto#hg%2Fssh
  • http://golang.org/pkg/crypto/rsa/
  • Basic coding example : http://stackoverflow.com/questions/21151714/go-generate-an-ssh-public-key
• Find a specific solution for Windows and implement it in the ssh.go using the os property in a switch ? Not good, puttyGen doesn't seem to handle command line
• Is Docker future Windows version handling it ? In that case, we should copy that if it's already resolved ?
• While ssh-keygen exists on Windows CMD thru cygwin/cygwin/etc., why not putting it as a requirement and ending machine commands if not found in the PATH. Quick solution to have a coherent user experience but not user friendly at all
• Make the key generation a requirements, letting the user choose its keygen tool. Same comments as for pushing ssh-keygen as requirements

Your opinions ?

from machine.

I think having a dependency on ssh-keygen is ok. We should check explicitly, as you mentioned, and give a good error message. The docs can recommend installing git-bash as a simple solution on Windows to provide ssh-keygen, as well as ssh itself (machine ssh command).

from machine.

Yeah, I think a dependency on ssh-keygen is okay, we just need a better error message.

from machine.

Closing as #257 was merged.

from machine.