Code Monkey home page Code Monkey logo

Comments (2)

abronan avatar abronan commented on June 30, 2024

Hi @seiffert, thanks for opening the issue. This sounds reasonable to me, I see that this is supported by the etcd client as well so we can just add this as store.Config options and use it on etcd New. And this will maintain backward compat for 2.0 (if you try to use username and password in this case it will just error out).

The only thing is that I'm not sure this is supported by etcd APIv3, as it uses gRPC for conns I don't see any field supporting username and password but just a plain TLS Config. The client is still in preview but I wanted to initiate the switch slowly as it provides with tons of enhancements. Will look into it. In the meantime I'm not against including this method of auth using the current client, this makes sense to me.

from libkv.

seiffert avatar seiffert commented on June 30, 2024

Hi @abronan, thanks for your comment!
Regarding the backward compatibility: I was just concerned about people using the 2.0 client library which does not yet have those attribute in their Config struct. However, most people have probably upgraded until now, what do you think?

from libkv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.