Make fails with `make: *** [binary] Error 1` about cli HOT 8 CLOSED

I guess it would be nice to be fixed or for the dockerized makefile to be the default one.

This was discussed in #78 as well: #78 (comment)

I think we'll look at replacing docker.Makefile with a ./build.sh for now

from cli.

What exact command did you run? make binary or just make ?

from cli.

just make

from cli.

I believe I fixed this in #78 , are you on latest master?

Edit: actually I fixed it for alpine, but not for "host" development. I dont' think we can support developing on the host.

Make fails with the helpful error message of make: *** [binary] Error 1

This is unfortunate, but that's how bash decides to error out on undefined variables with set -u.

from cli.

Yes I'm on latest master. Both make and make binary insta-fail on OSX.

from cli.

Oh, 🤦 this is the docker/cli repo, ignore me

from cli.

We could also add a check to the Makefile that warns if it's not being run from an expected environment. Maybe docker.Makefile (and the future ./build.sh) could set DOCKER_CLI_THIS_IS_FINE=1. Anyone who has setup their host can export that as well to remove the warning.

Then in Makefile if the environment variable isn't set we can warn "you probably want ./build.sh"

from cli.

This has been partially fixed by removing the "develop on the host" instructions from the README. We also have #99 to track other related improvements. #107 introduces the script I suggested here.

Going to close this issue since we have another tracking issue.

from cli.